Add row into mysql upon registration

[Nullifi3d]

I have a mod installed (my own) and I am redesigning the mysql structure. I decided to create it's own mysql table (banners). I need a row for every user.
Code to run upon registration:

PHP Code:

$db->query_write("INSERT INTO " . TABLE_PREFIX . "banners (userid, username, title, url, html, ext, width, height, clicks, available, impressions, status) VALUES ('$userid', '$username', '', '', '', '', '', '', 0, 0, 0, inactive)"); 


Will this code work in register_addmember_complete and is that the beast hook location to use for what I want to achieve?

Also, if I want to remove the row upon user deletion how would I go about doing so?

Please only reply if you are 100% certain your instructions are correct. This is being put into a live install.

[Marco van Herwaarden]

Originally Posted by HotLinkHosting

Please only reply if you are 100% certain your instructions are correct. This is being put into a live install.

It is extreme bad practise to develop on a live site. Nobody will risk answering you with this restriction.

It might work on that location, but you will have to test it.

About deleting, how many/often users get deleted? Better just leave it, maybe make a cronjob that cleans up once a month.

Is the username really needed in that table, why store it again if already stored in user table?

Do you really need all those columns? If not, you might want to add the columns just to the user table, would make things a lot easier.

Use prefixes for table (and if you will use the user-table also for columns) that make your names unique for your work (ie. tablename hlh_banners instead of banners), this will avoid possible future problems if names are used by future vB versions.

[Nullifi3d]

I normally don't mod live. The only reason I did this time was because I am moving the mod from the user table into it's own (banners). I actually decided afterwards that I don't need to delete as I don't delete users anyways, lol.

The reason why I wanted username stored is so I didn't have to query the table user and the table banners at the same time. If I can get it the same time I get all the other info from banners why do it otherwise? I do need all the columns as of right now (except username and html). html was only added in case I decide to store the html code that displays banners in the database (at a future time). width and hieght store the image dimensions so I don't have to find find them out each time a banner is displayed (i work with multi sized banners). ext is required so I know what kind of image is being displayed, url is the link and I allow users to specify a title for thier link. banners are not instantly approved so status column can have 3 different values. clicks and impressions are needed to show users their banner stats and available is needed to show the banner.

I'll take you up on your request to prefix the table banners.