[Adrian Schneider]

Your query was a little off (in logic, anyway). You were checking if there are any results from the registration table where the userid isn't the current user. If there are any registrations, this is always true.

I changed it so it checks if there isn't (actually if there is, then adding a ! in front of the whole condition so its the opposite) any registrations for the given user. Also, you should quote array keys if they are strings, because if 'userid' is a defined constant, you will run into problems.

PHP Code:

// ############################# START MAIN PAGE ###############################

// Check whether the user has registered for the game
if (!$vbulletin->GPC['do'])
{
    if (!$db->query_first("SELECT * FROM footy_registration WHERE userid = " . $vbulletin->userinfo['userid'] . ""))
    {
        standard_error(fetch_error('footy_youneedtoregister'));
    }
    else
    {
        eval('print_output("' . fetch_template('footy_main') . '");');
    }
}