View Single Post
  #1  
Old 04-18-2006, 04:53 AM
Gastongr Gastongr is offline
 
Join Date: Aug 2004
Posts: 65
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Need to know if this small code is well written

Hello,
some time ago i took a piece of code from a hack and made this file which displays the latest 5 threads whereever you put it.

PHP Code:
<?php 
$db_host 
"localhost";
$db_name "databasename";
$db_user "username";
$db_pw "dbpassword";

$forum_url "http://www.webmastershelp.com";
$limit "5";
$postedcolor "#404040";
$fontface "arial,verdana,geneva";
$txtlimit "50";
$num "0";


mysql_connect($db_host$db_user$db_pw
OR die (
"Cannot connect to your database"); 
mysql_select_db($db_name) OR die("Cannot connect to your database"); 

$tsql mysql_query("SELECT threadid,title,postusername FROM thread ORDER BY threadid DESC LIMIT $limit");

while(
$tget=mysql_fetch_array($tsql))
{
$num $num+1;
$title $tget['title'];
$tid $tget['threadid'];
$poster $tget['postusername'];
echo 
"<strong>$num.</strong> <a href=\"$forum_url/showthread.php?t=$tid\">$title</a><br /><font color=\"$postedcolor\" face=\"$fontface\" size='1'><i>posted by $poster</i></font><br /><br />";
}
?>
I'm getting mysql errors because "i have reachead" the max allowed mysql conections,
so my question is, could those errors be due to this small file?, is it well done?. i have modifyed it a lot but just small things, i don't really know php.

Could someone tell me if this code is ok?

well,
now that i think about it, i'm using three files like that one.
one for latest threads, one for latest members and one for topposters.
they all connect to the database and request information in everypage. these are the other two:

Newest members
PHP Code:
<?php 

$db_host 
"localhost";
$db_name "databasename";
$db_user "username";
$db_pw "dbpassword";
$forum_url "http://www.webmastershelp.com";
$limit "5"
$txtlimit "50"
$num "0";

mysql_connect($db_host$db_user$db_pw
OR die (
"Cannot connect to your database"); 
mysql_select_db($db_name) OR die("Cannot connect to your database"); 

$tsql mysql_query("SELECT userid,username FROM user ORDER BY userid DESC LIMIT $limit");

while(
$tget=mysql_fetch_array($tsql))
{
$num $num+1;
$title $tget['username'];
$tid $tget['userid'];
$poster $tget['joindate'];
echo 
"<strong>$num.</strong> <a href=\"$forum_url/member.php?u=$tid\">$title</a><br />";
}
?>
top posters

PHP Code:
<?php 
$db_host 
"localhost";
$db_name "databasename";
$db_user "username";
$db_pw "dbpassword";
$forum_url "http://www.webmastershelp.com";
$limit "5"
$txtlimit "50";
$num "0";

mysql_connect($db_host$db_user$db_pw
OR die (
"Cannot connect to your database"); 
mysql_select_db($db_name) OR die("Cannot connect to your database"); 

$tsql mysql_query("SELECT userid,username,posts,homepage FROM user ORDER BY posts DESC LIMIT $limit");

while(
$tget=mysql_fetch_array($tsql))
{
$posts $tget[posts];
$num $num+1;
$tid $tget['userid'];
$title $tget['username'];
$posts $tget['posts'];
$homepage $tget['homepage'];
echo 
"<strong>$num.</strong> <a href=\"";
if (
$homepage == '')
    {
    echo 
"$forum_url/member.php?u=$tid\">$title</a>";
    }
else
    {
    echo 
"$homepage\" target=\"_blank\">$title</a>";
    }

echo 
" <font color=\"$postedcolor\" face=\"$fontface\" size='1'><i>$posts posts</i></font><br />";
}
?>
Anyway to reduce the conections used by these scripts?
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01141 seconds
  • Memory Usage 1,821KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete