View Single Post
  #903  
Old 04-16-2006, 06:17 PM
stonyarc stonyarc is offline
 
Join Date: Aug 2005
Location: Leuven (Belgium)
Posts: 930
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by MrNase
One thing that bothers me a bit: On every update I have to re-upload the product file but that means all my translations are lost. Isn't there a way to prevent it? If you split up the language part I'll send you my German translation so that you can put it into the downloadable archive.

And now some things that came into my mind on upgrading my map:

The templates still are quite messy and at some point the even don't validate as XHTML anymore.
You are using '<BR>' instead of '<br />' and 'readonly' instead of 'readonly="readonly"'
The styling of the textboxes can better be done with CSS.

Besides that I have an idea to further improve the phrase support:
From what I see there are 4 places in the code where you are using an alert and those alerts are all hardcoded.
vB is using a method where the PHP variable is passed to a JS variable making it possible to use phrases in the JS code.

And speaking of the JS code: Wouldn't it be easier to make a new file with all the Javascript instead of placing them directly into the template?


Tell me what you think about my comments!


___________
I have one problem now: I can't update/change my location because the 2 input boxes won't change and the coordinates remain the same.
Code cleaning is on the list for 2.0.3

Are you still having that update problem?

My marker does show nicely http://www.pagodentreff.de/diskussio...hp?do=showmain



Your marker is somewhere in northern syberia. it's because of the default zoom you don't see.

Just center on Germany and hit update.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01299 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete