Thread: Toplist
View Single Post
  #567  
Old 03-10-2006, 06:57 PM
derekivey derekivey is offline
 
Join Date: Apr 2005
Location: Pennsylvania, USA
Posts: 1,186
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by derfelix
been testing it .. and it is great...

found one little bug.. (or feature? :surprised: )

Example:
A user uploads a pic.. and the sitename, description etc...
everything is fine..

now the user sees he has a typo in the text.. so he edits it.
when he saves it.. everything is fine..
BUT: the picture is gone.. as a matter of fact the file is still there..
but somehow in the db it is gone.. the user sees a broken image.

I think its a little bug in edit_site.php

because when you edit your sites it stores the $key variable into the database. BUT if you have not modified the image.. the variable $key is not defined anywhere (actually it takes the $key variable out of the included global.php)

My workaround is the following (maybe there is a more elegant way to do it)
First make a backup copy of edit_site.php


in edit_site.php
find:
PHP Code:
if (!empty($vbulletin->GPC['image']['name'])) 
above add:
PHP Code:
$query_key ""
a little lower find:
PHP Code:
$height $size[1]; 
below add:
PHP Code:
                    $query_key ", imagecode='" $key "' WHERE id='" $vbulletin->GPC['id'] . "'"
and finally find:
PHP Code:
                        imagesize='".$image_size."',
                        
imagecode='".$key."' WHERE id='".$vbulletin->GPC['id']."'"; 
and replace with:

PHP Code:
                        imagesize='" . $image_size . "'" . $query_key . ""; 
this is just a first guess..
maybe its not very elegant.. but it works for me.

which meens that when i edit a site without changing the image.. it does not delete the image.

Felix

-----------
As for the second little problem.. the dynamic image not showing.. its a problem with my localhost apache (test environment) that does not accept .htacess (but some providers dont either).

so what i did was:
rename the file image.png to image.php
then in the template Toplist_HTML_Code i replaced all 4 instances of image.png with image.php

for me its working now!!
It must be a bug, I could have swore I had it not change anything if they left the image field blank. Hmm. I will take a look and fix it.

Quote:
Originally Posted by Josh1
Which XML do i use??
product-toplist.xml
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01274 seconds
  • Memory Usage 1,790KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (6)bbcode_php
  • (2)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete