[mfarmerhi]

Originally Posted by contemptx

anyone managed to get this working or is this hacknow dead and we dont have a recurring payment hack for 3.0.x?

it would be great to get this hack working as i find 3.5 hogs cpu usage.

For 3.0.x versions, I believe there's an error in the instructions for Step #3 Open includes/functions_subscriptions.php

I believe it should read:

		case 'paypal':
		$form['action'] = 'https://www.paypal.com/cgi-bin/webscr';
		$form['method'] = 'post';
		/// Add In For Reacuring Payments
		$paypalextra = $DB_site->query_first("SELECT * FROM " . TABLE_PREFIX . "subscription AS subscription WHERE subscriptionid=$subscriptionid");
		if($paypalextra[reoccur]==0){// It is one time
		$form['hiddenfields'] = "
			<input type=\"hidden\" name=\"cmd\" value=\"_xclick\" />
			<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
			<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
			<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
			<input type=\"hidden\" name=\"amount\" value=\"$cost\" />
			<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
			<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
			<input type=\"hidden\" name=\"shipping\" value=\"0.00\" />
			<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]/$vboptions[forumhome].php\" />
			<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
			<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
			<input type=\"hidden\" name=\"no_note\" value=\"1\" />";

		}else{
		$form['hiddenfields'] = "
			<input type=\"hidden\" name=\"cmd\" value=\"_xclick-subscriptions\" />
			<input type=\"hidden\" name=\"business\" value=\"$vboptions[ppemail]\" />
			<input type=\"hidden\" name=\"item_name\" value=\"$title Subscription\" />
			<input type=\"hidden\" name=\"item_number\" value=\"$item\" />
			<input type=\"hidden\" name=\"currency_code\" value=\"$currency\" />
			<input type=\"hidden\" name=\"a3\" value=\"$cost\" />
			<input type=\"hidden\" name=\"p3\" value=\"$paypalextra[length]\">
			<input type=\"hidden\" name=\"t3\" value=\"$paypalextra[units]\">
			<input type=\"hidden\" name=\"src\" value=\"1\">
			<input type=\"hidden\" name=\"sra\" value=\"1\">
			<input type=\"hidden\" name=\"no_shipping\" value=\"1\" />
			<input type=\"hidden\" name=\"return\" value=\"$vboptions[bburl]\" />
			<input type=\"hidden\" name=\"notify_url\" value=\"$vboptions[bburl]/subscriptions/paypal.php\" />
			<input type=\"hidden\" name=\"custom\" value=\"$userinfo[username]\" />
			<input type=\"hidden\" name=\"no_note\" value=\"1\" />";
	
		}
			break;

As it was written, non-reoccurring subscriptions were not being updated by vB for Paypal users not using IPN; and subscriber were charged shipping. Further, as it was written Emails to the Admin didn't include the subscriber's names.

The updated code was taken directly from vB's original coding and, for the life of me, I can't see why it would have been changed in the if/else statement. The if/else statement takes care of non-reoccurring/reoccurring, but the coding for non-reoccurring should remain the same in either the hacked version or the non-hacked version. (Hope that makes sense...)

~ Mark