Thread: Administrative and Maintenance Tools - Quick (inline) User Editor
View Single Post
  #37  
Old 02-16-2006, 01:42 AM
andrefedalto andrefedalto is offline
 
Join Date: Dec 2005
Location: Brazil
Posts: 81
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by stark427
Nice mod.

I just wish the security risk could be resolved so that mods would not be able to upgrade themselves to admins

Does this also mean that moderators could degrade admins by putting them to the moderators usergroup?
here is a fix for security, because on my forums i allow admins, supermods and mods to edit users, so i had to add some security fixes, so the users cant get auto-promotted.

do the following:
open que.php and find (around line 121):
Code:
	// Merge the options with the users details
	$getoptions = convert_bits_to_array($user['options'], $vbulletin->bf_misc_useroptions);
	$user = array_merge($user, $getoptions);
now, BEFORE that, add:
Code:
	//Only administrators can edit administrators
	if ($vbulletin->userinfo['usergroupid'] != 6 && $user['usergroupid'] == "6" ) {
		eval(standard_error("Sorry, but you can't edit administrators!"));
	}

	//Super-moderators cant edit super-moderators
	if ($vbulletin->userinfo['usergroupid'] == "5" && $user['usergroupid'] == "5" ) {
		eval(standard_error("Sorry, but you can't edit super-moderators!"));
	}

	//Moderators cant edit super-moderators
	if ($vbulletin->userinfo['usergroupid'] == "7" && $user['usergroupid'] == "5" ) {
		eval(standard_error("Sorry, but you can't edit super-moderators!"));
	}
	
	//Moderators cant edit moderators
	if ($vbulletin->userinfo['usergroupid'] == "7" && $user['usergroupid'] == "7" ) {
		eval(standard_error("Sorry, but you can't edit moderators!"));
	}
Now only admins can edit admins, supermods cant edit other supermods and mods cant edit supermods or either mods.

now the mod is working fine for me...

//me clicks install
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01202 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete