[trilljester]

Originally Posted by yayvb

Hmmm, I had installed this lastnight and woke to find my users complaining that when they clicked page 2 of a thread they would be brought to a completely different thread!! I checked and sure enough that's what was happening.

So even if I fix the fact that on the main page only the first threads are rewritten, apparently if there is more than 1 page of posts in a thread, there is a bug making it so you get transported to the wrong thread instead of page 2 of the right thread.

Anyone else have this problem? I didn't see this in here already.

It's happening to me too. I might have to turn this promising extension off. It appears to be way too unstable to be released in a non-test environment. I think the problem in the logic for gathering the URL to rewrite is flawed, and with no way to debug the output, it makes it that much harder to figure out where the problem is coming from.

EDIT: Here's a function I used a long time ago to strip characters that could cause problems when I was scanning a URL. It might be useful for this extension.

function make_url_safe($text) {
// Characters must be in ASCII and certain ones are not allowed.
 $text = html_entity_decode ($text);
 $text = str_replace(" / ","-",$text);
 $text = str_replace("/","-",$text);
 $text = str_replace("'","-",$text);
 $text = str_replace(" - ","-",$text);
 $text = str_replace("_","-",$text);
 $text = str_replace(" ","-",$text);
 $text = str_replace( "?", "ae", $text);
 $text = str_replace( "?", "oe", $text);
 $text = str_replace( "?", "ue", $text);
 $text = str_replace( "?", "Ae", $text);
 $text = str_replace( "?", "Oe", $text);
 $text = str_replace( "?", "Ue", $text);
 $text = str_replace( "?", "ss", $text);
 $text = str_replace( "&", "and", $text);
 $text = str_replace( "%", "Percent", $text);
 $text = ereg_replace("[^A-Za-z0-9-]", "", $text);
 $text = str_replace("----","-",$text);
 $text = str_replace("---","-",$text);
 $text = str_replace("--","-",$text);
return $text;
}

So pass the preg_replace'd URLs through this filter to help. I don't know, it's worth a shot.