Excellent job! I missed all of my rewritten URLs when I converted from IPB to VBulletin. I know that Google can handle dynamic URLs to a degree, but I think this will improve my rankings out there.
Couple of bugs:
1. Send thread to a friend does not work. I commented it out for the plugin code, and now it's fine. It kept reporting a thread not found error, or something to that effect. The URL looked good, not sure where the problem was.
2. Viewing public profile of users has some issues. This is somewhat complicated, so I'll try my best to explain:
My user ID is #1. I have another frequent poster who's ID is 14. When we both post in a thread, her profile comes up as mine.
To see this in action, visit this thread:
http://www.trilliummud.com/holos/vis...h-my-1086.html
To see the bad behavior, hover over the first poster's url, and it reads:
http://www.trilliummud.com/holos/mem...uffho-631.html
The second post down was posted by Earthrooster. her user ID is 14. The URL for her profile is messed up. it reads:
http://www.trilliummud.com/holos/members/jester-1.html4
My profile works great though, as evidenced later in the thread:
http://www.trilliummud.com/holos/members/jester-1.html
It appears the regular expression is a little too general, and probably needs to be refined.
Other than that, everything else appears to be working great! I'll probably add some custom rewrites for my arcade, and can post them here, unless you have someplace else that we can post our custom rewrites for the next version?
Thanks!