View Single Post
  #14  
Old 01-17-2006, 10:02 PM
lazytown lazytown is offline
 
Join Date: Feb 2004
Posts: 503
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Sorry, I didn't mean to be rude in any way at all. Didn't mean to "spank you" at all. Your efforts are greatly appreciated and I was really looking for something like this. In fact I really love this mod. I just wanted to be honest to the rest of the users. I think it's very important that we examine that aspect of each mod on large forums. This one just happened to place the largest load I've ever seen out of over 50 mods I've tried/installed. I thought the warning was warranted. I don't make a habit out of it.

I wouldn't be presumptuous to tell you how you need to modify it in order to make it work "properly." Right now it does seem to work properly -- and on small forums with load to spare, I think it's fine.

I actually didn't think it would be that easy to change the mod to create a separate table. It would be a much larger hack. I'm not sure we are talking about the same thing. In order to make it truly efficient, a permanent table would have to be added to the database that gets updated with every post a user makes (very slight load increase for posting). This table would then be used by the mod and create almost no load upon viewing threads. There would have to be an initial post scan upon install to create the counts for each user (and possibly something that could be run separately in the future). That would be a very long query (scanning all posts for all users), but only run one time at install. As a bonus, something like that could make it easy to show how many posts a user has in each forum anywhere on the site (like in member profile, etc). If you did that, I would definitely use it and give you huge props.

How many total posts do you have in your forum? That will make an enormous difference on the server load this plugin adds. The load placed by the mod will grow as the posts grow.

My forum has about 1M posts and 11K members. On that size of a forum, this did double the time per page and I tested it several times when there was almost no one on the board. Since it scans the entire posts table for each and every post (10X per page) , it's easy to see how that load is placed.

Sincerely
-vissa


Quote:
Originally Posted by calorie
Thanks for the warning, but on my board this mod does not substantially increase server load or page display time (see attached screenshots) and that is probably true for some others also. While it wouldn't be hard for me to utilize a separate table and add a left join in the post query, the total overhead on my board is negligible either way, so the mod was created using separate count queries.

Something to remember is that my mods get tested on my board. It's rather off-putting to be spanked when it's not possible for me to test on your board, his board, her board. If you would have said something like, "Neat mod but would it be possible to do X instead of Y because Z happens?" I'd have been more inclined to redo the mod to help out, even though I don't need such a redo on my board.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01300 seconds
  • Memory Usage 1,770KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete