vb.org Archive - View Single Post

#15 09-07-2005, 05:10 PM

Quote:

Originally Posted by deathemperor

Thanks for your understanding.

yeah, i understand it completely, i knew it was not a final version...

i will report to you what is not done actually:

1- you did not use the proper $vbulletin->GPC[] structure for the globalised inputs... so it's impossible this script was tested for 3.5... look:

PHP Code:


			
        // get values in this way it's faster and more secure using vb fuction globalsize()

        $vbulletin->input->clean_array_gpc('p',array(

            'keyword' => TYPE_NOHTML,

            'searchfor' => TYPE_NOHTML,

            'searchdate' => TYPE_NOHTML,

            '_order' => TYPE_NOHTML,

            'orderby' => TYPE_NOHTML,

            'beforeafter' => TYPE_NOHTML

        ));

        // if string search is too short (less than 3 char)

        if (strlen($keyword) < 3)

        {

                eval(print_standard_error('searchnametooshort'));

        }

the "if (strlen($keyword) < 3)" will never find its content, as we need to use "$vbulletin->GPC['keyword']" instead... and this is it abroad your script actually... some changes are to be planned..

EDIT: for the calendar_quickreply, it's not compatible with the new editor, so half the features are not working... will have to be fixed!

for the others, just phrases, but actually it's not a problem i think... just the permissions sentences are needed.

and if you have time, i don't think it would be useful to wait 'til 3.5 Gold, your code use the minimum of vB codes actually, it will be easy to integrate in the final...

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01094 seconds Memory Usage 1,770KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_php (1)bbcode_quote (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: