vb.org Archive - View Single Post

#1 09-04-2005, 02:03 AM

Here's my edit_comment function, is it good? It's coding in OOP, though I kind of lost my understanding for it, so I'm going to have to reread on it. That's why I'm posting this, and also if it meets 3.5 syntax standards correctly, and if it's secure. This way, I can edit all my mistakes in previous functions I wrote. Any comments are greatly appreciated.

PHP Code:


			
function edit_comment() // edit comment

    {

    

    global $id, $vbulletin

        

        $this->id = $vbulletin->input->clean_gpc('g', 'commentid', TYPE_UINT);

        

        $getcomment = $vbulletin->db->query_first("SELECT comment_text, comment_title 

                                                   FROM space_comments

                                                   WHERE comment_id = '" . $this->id "'

                                                 ");

                                

        eval('$edit_comment .= "' . fetch_template('edit_comment') . '";');

        

        if ($_REQUEST['do'] == 'submit')

        {

            $vbulletin->input->clean_array_gpc('p', array('title' => TYPE_STR, 'text' => TYPE_STR))

            

            $this->title = $vbulletin->GPC['title'];

            $this->text = $vbulletin->GPC['text'];

    

            $add_edited_comment = $vbulletin->db->query_write("UPDATE space_comments

                                                               SET comment_title = '" . $db->escape_string($this->title) "', 

                                                                   comment_text = '" . $db->esacpe_string($this->text) "'

                                                               WHERE comment_id = '" $this->id "'

                                                              ");

                                                    

        }

    }

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01309 seconds Memory Usage 1,790KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_php (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: