View Single Post
  #7  
Old 08-05-2005, 12:39 AM
Andreas's Avatar
Andreas Andreas is offline
 
Join Date: Jan 2004
Location: Germany
Posts: 6,863
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

The Template is not the Problem, can be done with a Plugin.

Hook: forumbit_display
PHP Code:
if ($forum['link'])
{
    
$forum['replycount'] = '';
    
$forum['threadcount'] = '';
    eval(
'$forum[\'lastpostinfo\']  = "' fetch_template('linkhits') . '";');

This kicks off 1 File edit.

However, getting the count doesn't seem to be possible without the File edit.
The other Option would be to use a Query. But this would add 1 Query to Forumhome and every forumdisplay.php call where the Forum being displayed contains sub-forums that are links.
Or the Forumcache would have to be rebuild upon every Hit, which is even worse IMHO.

However, some furhter suggestions:

Your Counter-Update seems to be run every Time smth. is being done in ACP?
I'd suggest to get rid of the Settings and the admin_global Plugin.
Instead, make a new control in Forum Manager that shows the current Value so the User can just input it's own.

Hook: forumdata_start
PHP Code:
$this->validfields['linkhits'] = array(TYPE_UINTREQ_NO); 
Hook: forumadmin_edit_form
PHP Code:
if (trim($forum['link'] != ''))
{
    
$check $db->query_first("SELECT linkhits FROM " TABLE_PREFIX "forum WHERE forumid = $forum[forumid]");
    
print_table_header('Forum Link Hit Counter');
    
print_input_row('Hit Counter Value<dfn>Here you can manually adjust the Hit-Counter for this Forum-Link</dfn>''forum[linkhits]'$check['linkhits']);

The check-query isn't ideal, but necessary as the Forum Manager displays cached Data

Don't execute the Update in Global-Start, as this causes 1 additional Query for every Forum being displayed, no matter if it is a Link or not.

Hook: header_redirect
PHP Code:
global $foruminfo;
if (
trim($foruminfo['link']) != '')
{
    
$vbulletin->db->query("UPDATE " TABLE_PREFIX "forum SET linkhits = linkhits +1 WHERE forumid=$foruminfo[forumid]");

You should also cache the Template on forumdisplay, as it might be shown here too.

Hook: cache_templates
PHP Code:
if (THIS_SCRIPT == 'index' OR THIS_SCRIPT == 'forumdisplay')
{
    
$globaltemplates  array_merge($globaltemplates, array('linkhits'));

Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01853 seconds
  • Memory Usage 1,792KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (5)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete