[Logikos]

Originally Posted by Paul M

Five pages already, and for what ? This basically seems to be a few people who think they are better than everyone else wanting to mark down those who they think are not "good enough". What on earth is "php valid". If it works then it's valid - and "vB hackers will be encouraged to code properly" ?? properly in whose opinion ? Most people write hacks for their own boards and then release them here for others. When I do this I write in my style, no one elses, and I sure as hell will not put up with a "Warning" tag because it doesn't happen to suit someone else. Such labels will not help anyone, they will cause division and drive people away to release their work in more friendly places.

Exactly! Why should I indent my code? Because vBulletin does? Why should I add comments? Because vBulletin does? I will not recode my code to the standards to some team who thinks there code is better or easier to read. 80% of installers don't look at the code like that, they just follow instructions.

Whos to say that this is not valid

PHP Code:

$hacks = $DB_site->query("
        SELECT *
        FROM " . TABLE_PREFIX . "forum
        WHERE forumid = $forumid
"); 


Or that this isn't valid

PHP Code:

$hacks = $DB_site->query("SELECT * FROM " . TABLE_PREFIX . "forum WHERE forumid = $forumid"); 


Both do the same thing, one is just eaiser to read.