[sabret00the]

Originally Posted by Revan

I would very much like for you to show me the thread in the PHP forum that reads "Please help me verify this segment of code conforms to vBulletin Coding Standards".
If I ever saw such a thread, I would be happy to clean up the code for the user, and also post a link to the Manual, showing him where to reference for the future.
As for the people saying "If you clean the code for them, they'll never learn.", I disagree. What WILL prohibit learning is no-one they look up to pointing out the flaws in their coding. I could have an user with 5 posts tell me he disagreed with my coding standards (if it weren't for the fact that I already comply to an extensive degree with the vBulletin Coding Standards ), and I would simply ignore him.

no theirs no posts that say is this valid, but their are posts that ask how do you do this? why not show them with valid code?

and with the second thing i was speaking from a personal POV i know that if you tell me my codes wrong despite it working you lose my interest where as if you play with the words and your approach it can work wonders, it's like a woman with cleavage asking for a ride compared to a headmistress looking lass.

why dog on someone because they don't meet your interpretation or what something should be? if theirs no security holes give them time to improve themselves as i assure you for everyone you get to come round to your way of thinking, you'll get another that you caused to give up.

Originally Posted by Revan

I propose the following change to this idea:
4 levels of labels for a hack:

1. Valid - The hack complies with the vB Coding Standards both in terms of PHP and Source Code Formatting.
2. Cleared - The hack's PHP is optimised, but it has obvious flaws in Coding Style
3. Warning - Neither the hack's PHP or the hack's Coding Style complies
4. Pending - Pending evaluation (default for new hacks)

If a hacker is determined to become a part of the community, he will accept that he has to learn and not publically release 15 hacks before finally wising up his style.
There could even be a new forum where aspiring hackers can post their "raw" hacks for tips and pointers on how to optimise it and make it comply.

I just feel that I have seen too many horribly coded hacks (one of them is a major hack that is even SOLD, Darkwaltz4 will know what I'm talking about ).
Jelsoft creates out-of-the-box clean and fairly optimised code, they have spent many developer hours making their product more hacker friendly, something they really didn't HAVE do to, but did it anyways. Is it really fair to repay them by allowing any form of garbage (as garbage can come from experienced coders as well as newbies), degrading the performance of their product, then whine to them about how it's running slow? Hardly.

as i said make it automated utilizing PHP and regex's or not at all, that way theirs no people involved to hurt feelings and only the people that want their hacks validated get them validated.