View Single Post
  #54  
Old 08-02-2005, 09:32 AM
akanevsky akanevsky is offline
 
Join Date: Apr 2005
Posts: 3,972
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Since seemingly many of you here cannot read past the first post - I'd like ya'll to read it again.
I edited it to describe the NEW way the QA team would work.

Quote:
This isn't a highschool playground
Oh. And how come you acting like you are on one?

Quote:
You are treating it as if it is or should be...
You are right. It should be. Because amond PHP developers, Jelsoft's code is the best.

Quote:
1. Badly written code
AND
2. Well-written code that looks bad
In case 1, the code is badly written so that there are more queries, it is inefficient etc.
In case 2, the code works well, but just looks bad - ie. it's not formatted nicely in separate lines with comments.
I was actually talking about both. To help remove any excess queries or inefficiency plus help format the code the best way possible.

Quote:
Teaching him how to do it right is altogether different than chastising him in public with some sort of label. That will turn some otherwise good coders off from trying to learn and make it better.
Not teaching. Helping with suggestions...
People learn HTML. It is not cross-browser compatible in some ways, so it makes a lot more problems than pure formatting. Yet there you are - people learn both HTML and XHTML.

Quote:
i would never expect to pass QA or any other standard
You would not need to pass. Your hack will be published the same way as the ones marked by QA...

Quote:
Instead of "This hack is not quality assured and therefore is garbage"
Again, the hacks that have not been perfected, will not be marked as "garbage" in any way...
If they are, then you must agree that when there is a HOTM, all the rest of the hacks is marked as garbage.

Bottom line - nobody would "approve" or not "approve" anything. Just once a code of some hack has been perfected in ITS STRUCTURE, it would be marked as being so.

Quote:
about personal preferences..
There is such thing as common sense. And there are a few ways that when being followed make the code easier to read, edit and understand for the majority (except for the masochists).
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01164 seconds
  • Memory Usage 1,772KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (7)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete