View Single Post
  #1  
Old 08-01-2005, 10:24 PM
Revan's Avatar
Revan Revan is offline
 
Join Date: Jan 2004
Location: Norway
Posts: 1,671
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I offer my services as a member of the verification team as well. You remember from the Hack Manual Gen thread that I'm a perfectionist, so I would be one of those 4 or 5 I strive to achieve the standards in terms of coding style, but also actual coding (such as escaping DB values the vB way), templates, phrasing, etc
[/advertising to blag his way into the team]

I would applaud such a change, phpBB does it and it works for them, so why shouldn't it work for us?
Coupled with the Hack Database, this would IMO definetely be a huge step towards a better vBulletin coding community as a whole.

The sceptics might say "we can't force people to code a certain way", and while this is true, I fail to see why us hack installers should be forced to either clean up the code, or slowly watch our vBulletin installation buckle from poorly written hacks just because we desire/require the functionality it provides.
The vBulletin Coding Standards not only produce clean, easy to read/customise coding, it makes debugging easier. Imagine a script where an entire foreach() iteration is written on a single line, cramped together, then a parse error occurs. The line # would be the same, yet users (without syntax highlighting editors) would have to break up the line in order to pinpoint the error.
I fail to see a single good reason why these coding standards should continue being as undervalued as they are.

EDIT:
Quote:
Originally Posted by Brad
BTW we can't enforce people to code to standard anyway. Take a look at some of the 'experanced' coder's early hacks and you'll see what I mean, everyones ability to code develops over time with the help of others. Enforcing people to code to standard would deny people that option.
I disagree.
First of all, the vBulletin Coding Standards are mainly about code formatting. The ability to proper indent code, writing clean code, etc has nothing to do with someone's ability to code. I'm not saying we should get a bunch of Coding Nazis to fine coam each hack making sure they spaced their function arguments properly OR ELSE!!!, but there's a difference between that and some of the manure that Ive seen when looking at hacks.

Oh and just because you tried it before, doesn't mean you don't have new talent to help carry this out NOW. The hack database, as I understand it, was present before. Why not bring back this QA team, at least for a trial run?
The worst thing that can happen is the team being so totally backlogged that they have to give up, at which point the admins can simply disband the team and disable the Moderation (or whatever youll use to delay hack releases), and all is well
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01086 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete