View Single Post
  #51  
Old 07-02-2005, 05:21 PM
Cloudrunner's Avatar
Cloudrunner Cloudrunner is offline
 
Join Date: May 2003
Location: Butte, MT
Posts: 635
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by sv1cec
I read the above, but still in the code, there are instances that vBulletin uses $_REQUEST.

Can someone shed some light on this? Based on the above, I changed a program to use $vbulletin->GPC instead of $_REQUEST and the program no longer works. Switched back to $_REQUEST and everything works fine.

I am puzzled.

I think I need to elaborate:

In the past, I was using this part of code:

PHP Code:
// ########################## REDIRECT ###############################
if ($_REQUEST['do'] == 'nextstep')
{
    
globalize($_REQUEST, array(
        
'action' => STR,
        
'done' => STR
    
));
    if (empty(
$action))
    {
        
define('CP_REDIRECT'THIS_SCRIPT '.php');
    }
    else
    {
        
define('CP_REDIRECT'THIS_SCRIPT '.php?step=' $action);
    }
    
print_stop_message('redirecting_please_wait');

Now, the code has to be changed to:

PHP Code:
if ($_REQUEST['do'] == 'nextstep')
{

    
$vbulletin->input->clean_array_gpc('r', array(
        
'action'=> TYPE_STR,
        
'done'=> TYPE_STR,
    ));

    if (empty(
$vbulletin->GPC['action']))
    {
        
define('CP_REDIRECT'THIS_SCRIPT '.php');
    }
    else
    {
        
define('CP_REDIRECT'THIS_SCRIPT '.php?step=' $vbulletin->GPC['action']);
    }
    
print_stop_message('redirecting_please_wait');

I found this after a lot of trials and errors. What's the reason for having to check for $_REQUEST['do'] in the first if, and then use $vbulletin->GPC in the next parts? Where do I use $_REQUEST and where $vbulletin->GPC????
Do this instead to avoid that situation:
PHP Code:
$vbulletin->input->clean_array_gpc('r', array(
    
'do' => TYPE_STR,
    
'action'=> TYPE_STR,
    
'done'=> TYPE_STR)
);

if (
$vbulletin->GPC['do'] == 'nextstep'){
    if (empty(
$vbulletin->GPC['action'])){
       
define('CP_REDIRECT'THIS_SCRIPT '.php');
    } else {
       
define('CP_REDIRECT'THIS_SCRIPT '.php?step=' $vbulletin->GPC['action']);
    }
    
print_stop_message('redirecting_please_wait');

This effectively puts the $_REQUEST['do'] into the GPC, thus removing the need for the call to any $_REQUESTs. Of course, if you are only using the $_REQUEST['do'] to navigate through your script and not calling anything else, then you can leave the $_REQUEST calls and it will remove some overhead according to KirbyDE when I asked basically the same question.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01087 seconds
  • Memory Usage 1,794KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_php
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete