[MattKeys]

Well, I've seen a few things that I think should be changed/fixed. As there are already 33 pages of this thread I don't have time to go read all of the posts to see if someone mentioned this already, if it is just ignore me.

Fix:
Well, this most likely won't effect many people now that I think about it, but it may be better to fix anyway. If you are the only person in your group to get the ticket, and you send the ticket yourself (i was testing it out), you will get permission denied.

Sugguestion:
Make it pm everyone in the group that there is a *NEW* ticket, not just updated one.

I made both these fixes myself so it doesn't matter much to me, but for everyone else's sake. Before I did the fix I was telling everyone to submit it, then hit reply and say something else so that it would PM me and I didn't need to go look every 5 min. lol.



Oh, and mpadc:

Open helpdesk.php
Find: ('1'
Replace: ('insert userid here'


Edit:
Eh, I'll post what I did so you don't need to think so hard, btw, love the Addon.

The "Fix":
Open "helpdesk.php" (duh)
Find:

PHP Code:

    $updatequery = $DB_site->query("SELECT DISTINCT userid, username, pmpopup FROM " . TABLE_PREFIX . "user AS user WHERE (".$condition." OR userid = $ticketusergroups[postuserid]) AND userid <> $bbuserinfo[userid]"); 


Replace With:

PHP Code:

    $updatequery = $DB_site->query("SELECT DISTINCT userid, username, pmpopup FROM " . TABLE_PREFIX . "user AS user WHERE (".$condition." OR userid = $ticketusergroups[postuserid])"); 


Find:

PHP Code:

    while ($userinfo = $DB_site->fetch_array($updatequery))
    {
        sendprivatemessage ($userinfo, 'The following ticket has been updated:
[URL]'.$vboptions[bburl].'/helpdesk.php?do=ticket&tid='.$_REQUEST['tid'] . '[/URL]', 'HelpDesk Ticket Update');
    } 


Replace With:

PHP Code:

    while ($userinfo = $DB_site->fetch_array($updatequery))
    {
        if ($bbuserinfo[userid] != $userinfo[userid]){
            sendprivatemessage ($userinfo, 'The following ticket has been updated:
[URL]'.$vboptions[bburl].'/helpdesk.php?do=ticket&tid='.$_REQUEST['tid'] . '[/URL]', 'HelpDesk Ticket Update');
        }
    } 


Thats it for the fix.

Haven't done php in a while, if this is wrong just lemme know so I can take it down so I don't mess people up (works for me though).