View Single Post
  #1070  
Old 05-08-2005, 01:56 PM
calorie calorie is offline
 
Join Date: May 2003
Posts: 2,804
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Sorry, but I don't guarantee support for any of my mods. Perhaps this may make some people unhappy, but I have time constraints. There are other ideas that I have about the comments extension. Maybe I should start a thread in the Add-On forum, or maybe you are planning on integrating some of the things I posted? Anyway, you might want to make the following changes to your LFDB system. The first change prevents a search on "<h1>foobar</h1>" from interpreting the HTML, and the second change encodes the partial URL though it looks like it doesn't get used.

Code:
//===================================================================================================================
In the 'if ($_REQUEST['action'] == "show")' statement of local_links.php find:
//===================================================================================================================

	if ($sstring <> "") $message .= ' '.$vbphrase['ll_matching'].' '.$sstring;

//===================================================================================================================
And replace with:
//===================================================================================================================

	if ($sstring <> "") $message .= ' '.$vbphrase['ll_matching'].' '.htmlspecialchars($sstring,ENT_QUOTES);

//===================================================================================================================
In the 'if ($_REQUEST['action'] == "show")' statement of local_links.php find:
//===================================================================================================================

	if ($sstring <> "") $action = "&amp;search=$sstring";
	if ($sforum <> "") $action .= "&amp;forum=$sforum";

//===================================================================================================================
And replace with:
//===================================================================================================================

	if ($sstring <> "") $action = "&amp;search=".urlencode($sstring);
	if ($sforum <> "") $action .= "&amp;forum=".urlencode($sforum);
Quote:
Originally Posted by AndrewD
Hey man, I appreciate all the help - especially the facility to add comments - but is there a long string of these changes to come? If so, we need to think about how these will be supported as and when the main code evolves.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01237 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete