Sorry, but I don't guarantee support for any of my mods. Perhaps this may make some people unhappy, but I have time constraints. There are other ideas that I have about the comments extension. Maybe I should start a thread in the Add-On forum, or maybe you are planning on integrating some of the things I posted? Anyway, you might want to make the following changes to your LFDB system. The first change prevents a search on "<h1>foobar</h1>" from interpreting the HTML, and the second change encodes the partial URL though it looks like it doesn't get used.
Code:
//===================================================================================================================
In the 'if ($_REQUEST['action'] == "show")' statement of local_links.php find:
//===================================================================================================================
if ($sstring <> "") $message .= ' '.$vbphrase['ll_matching'].' '.$sstring;
//===================================================================================================================
And replace with:
//===================================================================================================================
if ($sstring <> "") $message .= ' '.$vbphrase['ll_matching'].' '.htmlspecialchars($sstring,ENT_QUOTES);
//===================================================================================================================
In the 'if ($_REQUEST['action'] == "show")' statement of local_links.php find:
//===================================================================================================================
if ($sstring <> "") $action = "&search=$sstring";
if ($sforum <> "") $action .= "&forum=$sforum";
//===================================================================================================================
And replace with:
//===================================================================================================================
if ($sstring <> "") $action = "&search=".urlencode($sstring);
if ($sforum <> "") $action .= "&forum=".urlencode($sforum);
Quote:
Originally Posted by AndrewD
Hey man, I appreciate all the help - especially the facility to add comments - but is there a long string of these changes to come? If so, we need to think about how these will be supported as and when the main code evolves.
|