View Single Post
  #930  
Old 04-28-2005, 05:19 AM
memobug memobug is offline
 
Join Date: Jun 2002
Posts: 418
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks for this!

The install went smoothly. A couple of notes:

1. Regarding The lines in GAS setting

URL to default image can be relative (i.e. gas/images/default.jpg)

Maybe I am misunderstanding something, but there seem to be a couple of problems here. The first is that this setting has a bug that inserts an extra slash in front of the link, making it become:
/http://www.domain.com/forum/gas/images/default.jpg
if you use a relative link it will enter a slash too

I think it has something to do with these "safety checks" in line 163. I had to comment them out to get it to stop inserting that slash:
Code:
# if(substr($GAS_setting['default_header_image'],0,1)!='/'){
#		 $GAS_setting['default_header_image'] = '/' . $GAS_setting['default_header_image'];
#		}
#

regardless of what you enter!

I also found that despite the fact that these two parameters say "CAN BE RELATIVE" in fact, the second link, the one to the default image, has to be relative. This is because the two get appended together!

The only way I could get an image out of it was to comment out all the safety checks - in particular this one that strips a slash off the end of the images directory

Code:
# if(substr($GAS_setting['url_to_header_images'],-1,1)=='/'){
#		 $GAS_setting['url_to_header_images'] = substr($GAS_setting['url_to_header_images'],0,strlen($GAS_setting['url_to_header_images'])-1);
#
and then use these settings:

URL to your images folder can be relative (i.e. gas/images) : http://www.mydomain.com/forum/gas/images/
URL to default image can be relative (i.e. gas/images/default.jpg):
default.jpg

Then when GAS appends the two together, I get good links!


A note:

2. I noticed that the path to the buttons was picking up my template path, so the buttons had to be reinstalled in the /buttons folder for the images associated to the template set where they were used.

A suggestion:

3. I think it would be great if a [BREAK] inserted a "Next Page" link right at the bottom of the template beneath the text Without it, it looks like the article is over and the user would think so unless he looked for the fiddly little Page 1 2 > links.

Thanks!

Matt
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01153 seconds
  • Memory Usage 1,769KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete