View Single Post
  #198  
Old 03-24-2005, 01:26 PM
mykes mykes is offline
 
Join Date: Feb 2005
Posts: 23
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

The hack created an interesting bug that I'm not sure has been reported.

In showthread.php, the old code looks like this (pre-hack):

Code:
if ($threadedmode != 1) // if linear or hybrid
{
  exec_header_redirect("showthread.php?$session[sessionurl_js]p=$getlastpost[postid]$highlightwords#post$getlastpost[postid]");
}
It's been changed to this (Geek Articles Hack version):

Code:
if ($threadedmode != 1) // if linear or hybrid
{
  exec_header_redirect("showthread.php?$session[sessionurl_js]p=$getlastpost[postid]$highlightwords#post$getlastpost[postid]&conly=$commentsonly");
				}
With the original code commented in, and the Geek Articles hack code commented out, things work proper. Comment in the articles hack code and things don't work right.

So let me define "don't work right."

If you are on forumhome page and click on the graphic next to a thread link "go to first unread/new post" then it takes you to some post in the thread maybe 2 or 3 posts BEFORE where the first unread/new post actually is. Or even in the middle of some post.

Here's an example of the URL that's generated, so you can see what's wrong:

showthread.php?p=2032241#post2032241&conly=

(I think having the &conly after #post confuses the browser)

The fixed code that works on my site looks like this:

Code:
	            // === GEEK ARTICLES step 5.4 ===
	            // WAS:
//				if ($threadedmode != 1) // if linear or hybrid
//				{
//					exec_header_redirect("showthread.php?$session[sessionurl_js]p=$getlastpost[postid]$highlightwords#post$getlastpost[postid]");
//				}
                // NOW:
				if ($threadedmode != 1) // if linear or hybrid
				{
					exec_header_redirect("showthread.php?$session[sessionurl_js]p=$getlastpost[postid]$highlightwords&conly=$commentsonly#post$getlastpost[postid]");
				}
				// === /GEEK ARTICLES ===
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01029 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (3)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete