View Single Post
  #181  
Old 12-05-2004, 04:22 AM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Revan
I had hoped I could just edit my post but meh gotta bump it now
I am in the process of installing this hack, and I must say I don't like having a table of its own for the warning_options. Im in the process of creating $vboptions for it all, then edit every part requiring this query to use $vboptions instead.
If you want, sv1, I can write up an installer part for adding into the datastore to help reduce query load for this hack (having 1 extra query ran every time I access the ACP just wont do for me )



EDIT: I am in the process of cleaning up the files, and this will be one of the issues I am fixing.


If you want, sv1, I can send you the files once Im done cleaning them up. It will be issues like the one quoted here, plus coding style I will be tampering with, Im not trying to make my own version of this
Raven,

Your idea of using $vboptions is a solid one, I didn't think of that, as I used ZT's original structure and I just used that table for my hack as well. The query for the options is indeed a pain. I wish I had thought about it, because now, I have to go back and edit all the files (not too ddifficult) and all the templates (gosh I hate that)! Darn!!!

And indeed, the code needs some cleaning work. Now that I've finished installing the other hack I mentioned above (the Inline Moderation Hack, great one), I think I'll spend some time cleaning up the mess.

Of course, your help is welcome, don't forget I started this from ZT's code, so a lot of the code is not mine either. An installer which will take into consideration the styles thing would be a great help, as I do not have any additional styles and I can't even help users with this issue. I just do not know how to handle them.

As for the Yes/No/Yes thing on the drop down menus, I am not sure I can do something about it, I am using vB's standard method, and that's how they show up after you set the value once.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01192 seconds
  • Memory Usage 1,767KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete