View Single Post
  #7  
Old 10-25-2004, 04:32 PM
Natch's Avatar
Natch Natch is offline
 
Join Date: Nov 2002
Location: Australia
Posts: 851
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

1] Your original code is
PHP Code:
<a href="#" onclick="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid; return false;">Execute Test Action</a
Should be
PHP Code:
<a href="#" target="windowname" onclick="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadid; return false;">Execute Test Action</a
^^ That would work, but it's not really ideal as you have no control over the structure or "features" of the window...

2] OK: the structure of the window.open() function is as follows...
Code:
window.open(this.href,this.target,"toolbar=yes, location=yes, directories=no, status=no, menubar=yes, scrollbars=yes, resizable=no, copyhistory=yes, width=400, height=400")
There was an omitted set of Quotes in my code above around the final argument of the function...

The structure can be broken down into three arguments: link URI, window name (same as target), and features.

Link can be either a quoted URI (eg "forumdisplay.php?f=1342") or a legal DOM reference (aka this.href refers to the contents of the href statement in this a tag... ).

Window Name similarly can be either a quoted value for the window name (eg "_blank", "mypopup") or a legal DOM reference (aka this.target refers to the target field in this a tag... ).

This example above uses the extended version of the code for features, the only features that require a name=value structure are width and height, the others you only need to include a feature name if you wish it to be active.

So: your code should be
PHP Code:
<a href="showthread.php?$session[sessionurl]do=testaction&amp;t=$threadidtarget="threadpop" onclick="window.open(this.href,this.target,'width=400,height=400,resize'); return false;">Execute Test Action</a
The reason this is a really ideal way of creating your popup links is that it will degrade well if users have JS turned off, in that a new window will still open, due to the target value being a real name, if it's blank, then it opens in this window...

Final Note:

A funky implementation or this is in the following example...
PHP Code:
<tr><td id="approach" class="row1" onmouseover="changeSty('row1hi',this.id)" onmouseout="changeSty('row1',this.id)" onclick="navCMPS(this.firstChild.href)"><a href="/somelink.php">a Linkage</a></td></tr
This is a part of a Navigation menu, and the two JS functions called are either changing the style onmouseover the Table Cell, or causing a link/popup to be called onclick of the Table Cell, without requiring much alteration for each new line... the opnly two changes reuquired are the link and name, and the link ID should be unique for each link...

HTH
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01066 seconds
  • Memory Usage 1,790KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_code
  • (4)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete