[Revan]

Originally Posted by mtha

In your file,

  	$softdelposts = $DB_site->query("
  		SELECT 
  			deletionlog.*,
  			deletionlog.primaryid AS postid, 
 		deletionlog.type AS deltype,			
  			deletionlog.userid AS userid, 
  			post.*,
  			post.title AS posttitle,
  			post.threadid AS threadid,
  			thread.*,
  			thread.title AS threadtitle,
  			thread.forumid AS forumid,
  			forum.*,
  			forum.title AS forumtitle,

post.* also has the userid value, this will take over the deletionlog.userid I would bring that line deletionlog.userid AS userid to the end of serquence, and put a link to deletor's profile:

In thread section
<strong>". $vbphrase['soft_deleted_by'].":</strong> <a href='" . $vboptions['bburl'] . "/member.php?u=". $thread['userid'] . "' target='_blank'>" . stripslashes($thread['username']) . "</a><br>


In Post section
<strong>". $vbphrase['soft_deleted_by'].":</strong> <a href='" . $vboptions['bburl'] . "/member.php?u=". $post['userid'] . "' target='_blank'>" . stripslashes($post['username']) . "</a><br>


PS. I added a phrase called soft_deleted_by as GLOBAL with the text: Deleted by (instead of using "NAME" phrase).



adding
print_table_break();

on top of
print_table_header($vbphrase['soft_deleted_posts']);

would also seperate two sections.


also, showing the total of soft deleted posts/threads (and/or the current number of thread) would be nice

something like

Soft Deleted Threads (showing thread 16 to 30 in total of 82 threads)
Soft Deleted Posts (showing post 16 to 30 in total of 511 posts)


here's the code:

Look for:
$countlog = $DB_site->query_first("SELECT COUNT(*) AS total FROM " . TABLE_PREFIX . "deletionlog");
Add after

PHP Code:

    $countthreads = $DB_site->query_first("SELECT COUNT(*) AS total    FROM " . TABLE_PREFIX . "deletionlog WHERE type = 'thread'");
    $countposts = $DB_site->query_first("SELECT COUNT(*) AS total    FROM " . TABLE_PREFIX . "deletionlog WHERE type = 'post'"); 


Look for (the first one)

print_table_header($vbphrase['soft_deleted_threads']);
while ($thread = $DB_site->fetch_array($softdelthreads))


Replace by

print_table_header("$vbphrase[soft_deleted_threads] (Total: $countthreads[total] threads)");
while ($thread = $DB_site->fetch_array($softdelthreads))

Look for

print_table_header($vbphrase['soft_deleted_posts]);
while ($post = $DB_site->fetch_array($softdelposts))

replace by

print_table_header("$vbphrase[soft_deleted_posts] (Total: $countposts[total] posts)");
while ($post = $DB_site->fetch_array($softdelposts))

About the post.*, when I tested it on localhost it always showed the mod name that deleted it, regardless of who the post belonged to.

I am implementing your changes on localhost now, and gonna see if theres a way to optimise it some (I always try my best to keep my query count to an all time low). Thanks alot for your suggestions Users like you, that are able to come up with simple yet very useful suggestions (even writing them ), is what makes hacks great and hack authors happy


//peace