[Dybukk]

I installed this hack....great work.

Only found one issue. If a user is already in the userban table and they reach the ban level you get a mySQL error since the code tries to INSERT a userid that already is in the table.

Also, is there a reason why the permanent ban usergroup can't be the same as the banned usergroup? I seem to remember reading that the banned usergroup is where the user returns to after being banned.

I was going to try and fix the SQL error myself by putting a check before inserting the user into the table. But I am a noob at php so I bet someone else has a better solution.

Edit:

Here is my solution, haven't fully tested it yet.

In Warn.php:

Find:

PHP Code:

$DB_site->query("
            INSERT INTO " . TABLE_PREFIX . "userban
            (userid, usergroupid, displaygroupid, customtitle, usertitle, adminid, bandate, liftdate)
            VALUES
            ($user[userid], $user[usergroupid], $user[displaygroupid], $user[customtitle], '" . addslashes($user['usertitle']) . "', $bbuserinfo[userid], " . TIMENOW . ", $liftdate)"); 


Replace with:

PHP Code:

if ($check = $DB_site->query_first("SELECT userid, liftdate FROM " . TABLE_PREFIX . "userban WHERE userid = $user[userid]"))
    {
        // there is already a record - just update this record
        $DB_site->query("
            UPDATE " . TABLE_PREFIX . "userban SET
            adminid = $bbuserinfo[userid],
            bandate = " . TIMENOW . ",
            liftdate = $liftdate,
            adminid = $bbuserinfo[userid]
            WHERE userid = $user[userid]
        ");
    }
    else
    {
        // insert a record into the userban table
        $DB_site->query("
            INSERT INTO " . TABLE_PREFIX . "userban
            (userid, usergroupid, displaygroupid, customtitle, usertitle, adminid, bandate, liftdate)
            VALUES
            ($user[userid], $user[usergroupid], $user[displaygroupid], $user[customtitle], '" . addslashes($user['usertitle']) . "', $bbuserinfo[userid], " . TIMENOW . ", $liftdate)
        ");
    } 


This was just a quirk I found and I don't really see it ever coming up since most banned users don't post. If you see errors in my code, let me know.