View Single Post
  #82  
Old 09-29-2004, 09:27 PM
memobug memobug is offline
 
Join Date: Jun 2002
Posts: 418
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Thanks TTG
Here's my update
1. I found a minor bug in the HTML printout that causes Thread block 4 to be labeled the same as thread block 3. You might want to edit it
replace
Code:
			$HTML_threadspreview4 .="	<td colspan=\"7\"><b><i>$title3</i></b></td>\n";
with the following:
Code:
			$HTML_threadspreview4 .="	<td colspan=\"7\"><b><i>$title4</i></b></td>\n";
It's somewhere around line 850 - I have added so much I can't be specific, but about midway down in the block that starts "if ($numtopics4)"

2. I have added the user-selected articles header back in. The text version is working well but for the HTML version to be usable I would need to have a way of ensuring that truncating the message doesn't split HTML tags or tag pairs, or it could mess up the rest of the message.

update - I got around this by using a tag like -MORE- right in the post. Then I made the commbull trim the article right at the tag, and there is no danger of cutting in a bad place!

3. I got rid of 222 lines of code in commbull.php by removing the redundant iterations of the same code for thread blocks 2, 3, 4 as were used in block 1.

4. I found a problem when I designated some 24 forum members in a special public group called proofreaders. When I tried to send the newsletter to them for proofing commbull complained that there were no users. I had to fix two queries to enable it to recognize the auxilliary user groups.

All in all, with the exception of not having any calendar or birthday events working, it came off pretty well. I sent out 2800 newsletters this afternoon.

Matt
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01876 seconds
  • Memory Usage 1,765KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete