View Single Post
  #10  
Old 09-21-2004, 11:15 AM
Spinball's Avatar
Spinball Spinball is offline
 
Join Date: Feb 2002
Location: Telford, England
Posts: 705
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Paul - I've installed your hack as per the instructions, but I'm getting IP addresses being saved by proxy users in the post table such as
192.168.1.7, 82.
172.26.106.249,
unknown, 10.255.
10.20.5.2, 194.2

I'm regarding this is quite a serious error as IP information needs to be correct.

PHP Code:
I've looked at the bit of code which I think gets the real IP in init.php :
// ####################### HN getproxyip START########################
// Establish Proxy Server IP address (if it exists) and Real IP Address
// Make sure forum always uses real client IP address 
// Start of Paul Marsden Proxy Hack Modification
if ($_SERVER['
HTTP_X_FORWARDED_FOR'] != '') 

    $proxyip = $_SERVER['
HTTP_X_FORWARDED_FOR']; 

else if ($_SERVER['
HTTP_CLIENT_IP'] != '') 

    $proxyip = $_SERVER['
HTTP_CLIENT_IP']; 

else if ($_SERVER['
HTTP_FORWARDED'] != '') 

    $proxyip = $_SERVER['
HTTP_FORWARDED']; 

else 

    $proxyip = ''; 

$proxyip = preg_replace('
/javascript/i', 'java script', $proxyip); 
$proxyip = str_replace('"', '"', $proxyip); 
$proxyip = str_replace('
<', '&lt;', $proxyip); 
$proxyip = str_replace('
>', '&gt;', $proxyip); 
if (!preg_match("#\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}#", $proxyip))
{
    $proxyip = ''; 
}
if ($proxyip == '')
{
    define('
PROXYIP', ''); 
    define('
IPADDRESS', $_SERVER['REMOTE_ADDR']);
}
else
{
    define('
PROXYIP', $_SERVER['REMOTE_ADDR']);
    define('
IPADDRESS', $proxyip); 
}
unset($proxyip); 
// End of Paul Marsden Proxy Hack Modification
// ####################### HN getproxyip END ######################## 
Is this code in error?
Please help!
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01317 seconds
  • Memory Usage 1,781KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete