[BamaStangGuy]

if (!($forumperms & CANGETATTACHMENT)) 
{ 
    $vboptions['viewattachedimages'] = 0; 
    $vboptions['attachthumbs'] = 0; 
} 

// check if there is a forum password and if so, ensure the user has it set 
    verify_forum_password($attachmentinfo['forumid'], $attachmentinfo['password']); 

$pmUsers = $DB_site->query_first("SELECT toUserArray FROM ".TABLE_PREFIX."pmtext WHERE pmtextid='".$attachmentinfo['private']."'"); 
    $toUserArray = unserialize($pmUsers['toUserArray']);          
    if ($toUserArray[$bbuserinfo['userid']] != $bbuserinfo['username'] && $attachmentinfo['userid'] != $bbuserinfo['userid']) { 
            print_no_permission();         
           }

It works fine until I had this part. Id di it in steps. Aded the first uploaded images showed. Added the second part images still showed. When I added the above part the images broke.

It still does it with what you posted in your lsat post as well