[Revan]

I would like to submit the following comments to this guide.

Originally Posted by Oblivion Knight

How do I switch between ASCII and Binary mode?
Again, this depends on which FTP Browser you use. Key words to look out for on the toolbars for this would be 'A-1 Mode' and 'Transfer Mode'. If you have problems finding this, ask at the support forums of your chosen FTP Browser, or asking at a vBulletin community might be helpful (as long as you're polite!).

You should also add that ALL the FTP clients you suggested supports the AUTO transfer mode, which (amongst others) automatically transfers PHP files in ASCII mode (which is the relevant file type and transfer mode for 99 % of all vB related transfer).

Originally Posted by Oblivion Knight

What program should I use to edit my files?

The most common question asked where vB hacking is concerned is; "What program should I use to edit my files?" The answer is, there is no definitive program to use.. Some work better much better than others however.

Recommended:
Notepad, Developers Pad, EditPlus, UltraEdit

Not Recommended:
Microsoft Word, Wordpad, Macromedia Dreamweaver

Notepad will get you by just fine, but the major features it lacks (syntax highlighting, line numbers and customizable keyboard shortcuts) can be found in the other recommended programs; Developers Pad, EditPlus and UltraEdit.

What program did you use to edit the files?
If you used Macromedia Dreamweaver, it's likely that something else was changed on top of what you asked it to change. The program is funny like that..

No it bloody well isnt.
I strongly resent the ENTIRE part of this post.
I used Dreamweaver for 90 % of my coding career, and not ONCE has it (nor FrontPage for that matter) fooked up my files.
The ONLY reason why it would EVER destroy vB code is if you, in your preferences, turned ON code rewriting.
Now I got code rewriting on, and yet DW doesnt mess up my vB files!?
OMFG!
I just put .php and .php3 as an extension in "Never rewrite code files with the following extensions:"

I cannot express thoroughly enough how much it PISSES ME OFF that someone just writes "Dreamweaver is not recommended because it destroyd vB coding", without actually bothering to check what the cause is and try to resolve it internally.

Originally Posted by Oblivion Knight

I get a syntax error when running this query.. Help!
Syntax errors are often enough the result of bad copying and pasting, or depending on what you're using to run database queries the query string may differ.

If you get a syntax error when running code with a ';' at the end of it, remove the ';' and try running it again. This SHOULD solve your problem.

Other things to look out for are too many ' marks used in the query. A good example of this would be the following query that you are asked to run when installing the Journal.. Please note that this is not a definate answer, different versions of phpMyAdmin may act differently.

Correct :laugh:[sql] CREATE TABLE journal (
journalid int(11) NOT NULL auto_increment,
title text NOT NULL,
description text NOT NULL,
imagename text NOT NULL,
entries int(11) NOT NULL default '0',
views int(11) NOT NULL default '0',
enabled smallint(6) default '0',
timestamp int(11) NOT NULL default '0',
userid int(11) NOT NULL default '0',
mood text NOT NULL,
np text NOT NULL,
PRIMARY KEY (journalid)
) TYPE=MyISAM ;[/sql]
Incorrect :dead:[sql] CREATE TABLE journal (
'journalid' int(11) NOT NULL auto_increment,
'title' text NOT NULL,
'description' text NOT NULL,
'imagename' text NOT NULL,
'entries' int(11) NOT NULL default '0',
'views' int(11) NOT NULL default '0',
'enabled' smallint(6) default '0',
'timestamp' int(11) NOT NULL default '0',
'userid' int(11) NOT NULL default '0',
'mood' text NOT NULL,
'np' text NOT NULL,
PRIMARY KEY ('journalid')
) TYPE=MyISAM ;[/sql]

Your "correct" SQL query syntax, while it works just perfect, is not 100 % correct.
The syntax as SQL itself shows it, is:
[SQL]CREATE TABLE `journal` (
`journalid` int(11) NOT NULL auto_increment,
`title` text NOT NULL,
`description` text NOT NULL,
`imagename` text NOT NULL,
`entries` int(11) NOT NULL default '0',
`views` int(11) NOT NULL default '0',
`enabled` smallint(6) default '0',
`timestamp` int(11) NOT NULL default '0',
`userid` int(11) NOT NULL default '0',
`mood` text NOT NULL,
`np` text NOT NULL,
PRIMARY KEY (`journalid`)
) TYPE=MyISAM;[/SQL]
The ONLY reason why you have syntax errors in your "incorrect" query is because usage of ' in the name area is not permitted, you must either use ` or none.


Other than these errors in your guide, its very well written.