Dewayne,
Great, that did it. One small problem, it breaks the PM system, when you try to view a PM. We need to have that part of the code, work only in showthreads and not in ... showPM (that doesn't exist obviously, just joking).
What happens is that when a user tries to see one of the PMs in his inbox, the query is run and he gets the following error:
Database error in vBulletin 3.0.1:
Invalid SQL:
SELECT postid
FROM post
WHERE threadid=
ORDER BY dateline
LIMIT 1
mysql error: You have an error in your SQL syntax near 'ORDER BY dateline
LIMIT 1
' at line 5
mysql error number: 1064
Date: Wednesday 28th of July 2004 02:19:04 AM
Script:
http://forum.m1911.org/private.php?do=showpm&pmid=733
Referer:
http://forum.m1911.org/private.php?
Username: John
IP Address:
Here is what I found:
Replace the QE code in includes/function_showthread.php, with the one below:
PHP Code:
// Quick Edit hack
if (THIS_SCRIPT=='showthread' AND $post['editlink'] AND $bbuserinfo[userid]>0)
{
$forumperms = fetch_permissions($thread['forumid']);
// find out if first post
$getpost = $DB_site->query_first("
SELECT postid
FROM " . TABLE_PREFIX . "post
WHERE threadid=$thread[threadid]
ORDER BY dateline
LIMIT 1
");
if ($getpost['postid'] == $post['postid'])
{
$isfirstpost = true;
}
else
{
$isfirstpost = false;
}
if ($isfirstpost AND can_moderate($thread['forumid'], 'canmanagethreads'))
{
$show['deletepostoption'] = true;
}
else if (!$isfirstpost AND can_moderate($thread['forumid'], 'candeleteposts'))
{
$show['deletepostoption'] = true;
}
else if (((($forumperms & CANDELETEPOST) AND !$isfirstpost) OR (($forumperms & CANDELETETHREAD) AND $isfirstpost)) AND $bbuserinfo['userid'] == $post['userid'])
{
$show['deletepostoption'] = true;
}
else
{
$show['deletepostoption'] = false;
}
if ($post['userid'] == $bbuserinfo['userid'])
{
$edittext = htmlspecialchars_uni($post['pagetext']);
eval('$quickedit = "' . fetch_template('showthread_quickedit') . '";');
}
else
{
$edittext="";
$quickedit="";
}
}
// End Quick Edit hack
With this if in the beginning, it works fine.
Below is my version of the showthread_quickedit template. I've made it a bit cramped, so that it is indeed a QUICK edit. It includes the editing and the deleting function.
HTML Code:
<span id="quickedit_$post[postid]">
<img src="$stylevar[imgdir_button]/quickedit_icon.gif" alt="Quick Edit" border="0" />
<script type="text/javascript"> vbmenu_register("quickedit_$post[postid]", true); </script>
</span>
<div id="quickedit_$post[postid]_menu" style="display:none">
<form enctype="multipart/form-data" name="vbulletinform" style="display:inline;" action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="do" value="updatepost" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="posthash" value="$posthash" />
<input type="hidden" name="poststarttime" value="$poststarttime" />
<input type="hidden" name="emailupdate" value="9999" />
<input type="hidden" name="disablesmilies" value="0" />
<input type="hidden" name="parseurl" value="1" id="cb_parseurl" />
<input type="hidden" name="iconid" value="$post[iconid]" />
<table class="tborder" cellpadding="6" cellspacing="1" border="0" width="100%" align="left" bgcolor="#D6DAE5">
<tr>
<td bgcolor="#3A5383" align="left">
<TABLE width="100%">
<TR>
<TD align="left"><font color="#ffffff">
$vbphrase[edit_post]</FONT>
</TD>
<TD align="right"><font color="#ffffff">
<div class="smallfont" align="right">Click anywhere outside this box, to cancel editing.</DIV></FONT>
</TD>
</TR>
</TABLE>
</td>
</tr>
<tbody>
<tr valign="top">
<td class="panelsurround" align="center">
<div class="panel">
<div align="left">
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[reason_for_editing]:</div>
<div><input type="text" class="bginput" name="reason" value="$newpost[reason]" size="50" maxlength="200" tabindex="1" title="$vbphrase[optional]" /><input type="hidden" name="reason_exists" value="$edit[reason_exists]" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>New $vbphrase[title]:</div>
<div><input type="text" class="bginput" name="title" value="$post[title]" size="50" maxlength="85" tabindex="1" /></div>
</div>
<div class="smallfont" style="margin-bottom:$stylevar[formspacer]px">
<div>$vbphrase[message]:</div>
<div><textarea name="message" class="bginput" style="width:470px; height:125px;" wrap="virtual" tabindex="1">$edittext</textarea></div>
</div>
</div>
</div>
<TABLE width="100%">
<TR>
<TD ALIGN="LEFT">
<if condition="$bbuserinfo['signature'] != ''">
<input type="checkbox" name="signature" value="1" checked /><span class="smallfont">Signature</span></if>
</TD>
<TD ALIGN="RIGHT">
<input type="submit" class="button" name="sbutton" value="Save Changes" accesskey="s" tabindex="1" />
</TD>
</TR>
</TABLE>
</td>
</tr>
</tbody>
</form>
<if condition="$show['deletepostoption']">
<form action="editpost.php" method="post">
<input type="hidden" name="s" value="$session[sessionhash]" />
<input type="hidden" name="p" value="$post[postid]" />
<input type="hidden" name="do" value="deletepost" />
<tr>
<td bgcolor="#3A5383" align="left">
<font color="#ffffff">$vbphrase[delete_this_message]</font>
</td>
</tr>
<tbody id="collapseobj_editpost_delete" style="$vbcollapse[collapseobj_editpost_delete]">
<tr>
<td class="panelsurround" align="center">
<div class="panel">
<div align="$stylevar[left]">
<div class="fieldset">
$vbphrase[delete_message_check_appropriate_option]
<if condition="$isfirstpost">
$vbphrase[deleting_message_deletion_of_thread]
</if>
</div>
<fieldset class="fieldset">
<legend>$vbphrase[delete_options]</legend>
<div style="padding:$stylevar[formspacer]px">
<div>
<label for="rb_del_leave"><input type="radio" name="deletepost" value="" id="rb_del_leave" tabindex="1" checked="checked" />$vbphrase[do_not_delete_message]</label>
</div>
<div>
<label for="rb_del_soft"><input type="radio" name="deletepost" value="delete" id="rb_del_soft" tabindex="1" />$vbphrase[delete_message]</label>
<if condition="$show['physicaldeleteoption'] AND $show['keepattachmentsoption']">(<label for="cb_keepattachments"><input type="checkbox" name="keepattachments" value="1" id="cb_keepattachments" tabindex="1" />$vbphrase[keep_attachments]</label>)</if>
</div>
<if condition="$show['physicaldeleteoption']">
<div>
<label for="rb_del_hard"><input type="radio" name="deletepost" value="remove" id="rb_del_hard" tabindex="1" />$vbphrase[physically_remove_message]</label>
</div>
</if>
</div>
</fieldset>
<div class="smallfont">
<div>$vbphrase[reason_for_deletion]:</div>
<input type="text" class="bginput" name="reason" size="50" tabindex="1" title="$vbphrase[optional]" />
</div>
</div>
</div>
<TABLE width="100%">
<TR>
<TD ALIGN="LEFT">
<div class="smallfont">Click anywhere outside this box, to cancel editing.</div>
</TD>
<TD ALIGN="RIGHT">
<input type="submit" class="button" value="$vbphrase[delete_this_message]" tabindex="1" accesskey="s" />
</TD>
</TR>
</TABLE>
</td>
</tr>
</tbody>
</form>
</if>
</table>
</div>
Maybe this helps some other folks here.
Rgds
More Information