View Single Post
  #187  
Old 07-24-2004, 06:45 PM
sv1cec sv1cec is offline
 
Join Date: May 2004
Location: Athens, Greece
Posts: 2,091
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

EvilLS1, thanks for coming back to me, I wish all developers here were as prompt as you are. Also, thanks for the nice words on M1911.ORG, appreciated.

As far as the hack is concerned, please read my comments below:

Quote:
Originally Posted by EvilLS1
sv1cec,
Thank you for your suggestions. I will address a few of them now but others will have to wait until the next version as I don't have much time to work on hacks these days.
Thank YOU, for taking the time to help us all.


Quote:
Yes I've noticed that too. It seems to be a browser specific problem (mozilla/firefox) and I can't figure out the solution for the life of me. I will figure it out before the next version is released.
I guess I can live with it for the time being, I do not think anyone will be crazy enough to press QE and then cancel it so many times to have the window move out of the screen. What's wierd is that this does not happen if you "Save" the edited post. In this case, the window gets opened in the same position, every time. It shifts to the left, only if you cancel and re-edit.


Quote:
This is by design. I wanted the window to open below the post so that the user can still see the original post while editing. Should be fairly easy to change though.
That, I would appreciate it. The way it works now, it's sometimes possible to not notice that the window has opened. It happened to me once, so I guess it can happen to others, who are used to leaving the buttons down on their screen while reading the posts, and hit one of them to edit or quickreply. If you can show me the code, I can ... test it. And since the new window shows the existing post text, it is not necessary to be able to see the post in the background. What I would suggest is to have the window open, right next to the button, with the button being about the middle of the windows height. In that way, the window will be apparent, no matter where the QE button was when it was pressed.

Quote:
Thats a good idea. Quick delete would be handy for those who have that privilege. I'll add that to the next version.
I guess it shouldn't be too difficult, maybe we can copy the code from the standard Edit form. I'll give it a try tomorrow morning (late night for you) and I'll update you on my results.

Quote:
IMO its not a good idea to allow mods/admins to quickedit all posts and here's why: With the way this hack works it must load the post text two times in posts where the viewer has the ability to quick edit. So if you set it so that admins can quickedit all posts the post text for every post within a thread will be loaded twice in his browser (once viewable and once hidden) which could slow down the load time a bit. Theres also a problem with the moderater log not showing some info for posts that were quick edited by mods & admins. This is why I didn't include that feature with the hack in the first place. If you still want to allow staff to edit all posts let me know and I'll post the code changes.
Oh no, I do not want that. I was not aware that the contents of the posts which are QE-table are loaded twice. If you do what I suggested, it will take twice as much time to load a page than before, so cancel that ... request Sir.


Quote:
In the first version of QE there was a cancel button which closed the window. The newest version uses vB's standard vbmenu_popup to show the Quick Edit box. This is the same function that shows the little drop down box of links when you click on someones username within a post. It also works the same way so when you want to exit the box you just click somewhere on the page and it will disappear. If you'd rather use the first version it can be found here:
https://vborg.vbsupport.ru/showpost....3&postcount=95
(also, the first version doesn't seem to have the problem with mozilla where the window opens further to the left every time its clicked, so you may like it better)
I tried that version and it's not as good as yours. When you click on the Edit Post text (or the button, that's irrelevant), the screen skips to the top of the page and you have to scroll down to find the new window. From the way this vB feature works, in the menu on the user name, and the window of QE, I assume you have missed something. I mean, in QE it seems as if the window is somehow occupying the whole width of the screen. If you click to the left or to the right of the window, the program thinks you are clicking in the window and it does not close. You have to click either above or below that screen area, to close the window. I'll try and figure out how the code for the little menu works and see if I can find anyway to solve that problem, and keep you posted. But, please, if you come up with something let me know. It's quite confusing for the end user. Also, that Gold version does not handle the signatures properly, while yours works fine for me.

Quote:
Thank you. I've added a link to your post in the first post of this thread so that people may use your image.
I am honored, I haven't done anything worthwhile to be included there. If you want, I can give you the code I have come up for my pop-up window, which I think is more ... beautiful than yours (no pan intended), and does away with the preview button. If someone wants to have the full editing features, he can use the normal Edit button. The QE is just for quick work, so I decided that the Preview is not necessary.

Well, enough said, I'll work on this tomorrow early in the morning and post accordingly.

Again, many thanks for a great hack, appreciated.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.02043 seconds
  • Memory Usage 1,792KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (7)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete