View Single Post
  #59  
Old 01-13-2004, 10:58 AM
Cloudrunner's Avatar
Cloudrunner Cloudrunner is offline
 
Join Date: May 2003
Location: Butte, MT
Posts: 635
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Quote:
Originally Posted by Link14716
I'll look into it. It seems like an RC2 installer bug. Install it from the RC1 installer insetad for now.
Looking at the install code for RC2, I'm personally thinking that perhaps it lies somewhere around here?

Between line 84 and line 100
Code:
	if ($vboptions['shoutbox_version_no_touch'] != SHOUTBOX_VERSION_SH) {
		// Version auto-detected (RC1 and above)
		echo "We have automatically detected your shoutbox verion. You may start the upgrade process by clicking the link below.<br /><br />";
		echo "<a href='".THIS_SCRIPT.".php?step=2&amp;version=".$vboptions['shoutbox_version_no_touch']."'>Click here to continue.</a>";
		exit;
	} elseif ($vboptions['shoutbox_version_no_touch'] == SHOUTBOX_VERSION_SH) {
		echo "We have automatically detected your current shoutbox version, and it appears to be up-to-date.";
		exit;
	} else {
		// Version cannot be auto-detected (Gamma 1 and below)
		echo "We cannot detect your shoutbox version. This means that you are running 1.0 Gamma 1 or below, or have not installed the shoutbox yet. You may use this script to continue upgrading <b>but only if you are running 1.0 Gamma 1 or doing a clean install</b>! This script cannot upgrade your shoutbox if you are running Beta 5 or below, so upgrade to Gamma 1 manually first!<br /><br />";
		echo "If you are running 1.0 Gamma 1, ";
		echo "<a href='".THIS_SCRIPT.".php?step=2&amp;version=10g1'>click here to start the upgrade to ".SHOUTBOX_VERSION.".</a> ";
		echo "If you want to do a new install of the shoutbox, ";
		echo "<a href='".THIS_SCRIPT.".php?step=2&amp;version=new'>click here to install ".SHOUTBOX_VERSION.".</a> ";
		exit;
	}
Since back on line 61 your conditionals look for shoutbox_version_no_touch, and if not found they set $nextversion = "1.0 Release Candidate 1", but in the line 84 code it again looks for the shoutbox_version_no_touch, but has nothing in that conditional about the $nextversion variable?

Perhaps adding a conditional that compares what was set in $nextversion versus what is in SHOUTBOX_VERSION, or SHOUTBOX_VERSION_SH? The reason I say this is that for a clean install the following (from line 84) will always be "true":
Code:
$vboptions['shoutbox_version_no_touch'] != SHOUTBOX_VERSION_SH
because $vboptions['shoutbox_version_no_touch'] will be non-existant on a clean install, and therefore will never be = SHOUTBOX_VERSION_SH.

did that even make sense?
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01311 seconds
  • Memory Usage 1,770KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)bbcode_quote
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete