[Kentaurus]

Originally Posted by Boofo

Does the regular attachments work the same way, or are they doing an unset?

The regular attachments are deleted when the post is deleted or the user deletes the attachment via the usercp, in my hack I forgot to write some code to delete any unused attachment.

In private messages it is a little more tricky because the same private message can be reused between multiple recipients, so we need to make sure that nobody needs the pmtext. Vbulletin does it by using an hourly cleanup to delete all orphan pmtext, I made it delete the attachments there also.

################################################## #################
# Code modifications in file "includes/cron/cleanup2.php"
################################################## #################
-------------------------------------------------------------------
at line 81, search for this code:
-------------------------------------------------------------------

 $pmtextids = '0';
 while ($pmtext = $DB_site->fetch_array($pmtexts))
 {
  $pmtextids .= ",$pmtext[pmtextid]";
 }
 $DB_site->query("DELETE FROM " . TABLE_PREFIX . "pmtext WHERE pmtextid IN($pmtextids)");
}
$DB_site->free_result($pmtexts);

------------------------------------------------------------------
change it to:
-------------------------------------------------------------------

 
 $pmtextids = '0';
		
		$pmtextidsAttach = "";
		$pmtextAttach = array();
		
 while ($pmtext = $DB_site->fetch_array($pmtexts))
 {
  $pmtextids .= ",$pmtext[pmtextid]";
				$pmtextAttach[] = $pmtext[pmtextid];
 }
		$pmtextidsAttach = implode(",",$pmtextAttach);
 $DB_site->query("DELETE FROM " . TABLE_PREFIX . "pmtext WHERE pmtextid IN($pmtextids)");
}
$DB_site->free_result($pmtexts);

// Attachments for orphaned pmtext records are removed
// Let's be very careful with this delete, a delete from attachment where private IN (0) will purge all non-private attachments
// that's why an extra $pmtextidsAttachments is created instead of reusing the old one 
if ($pmtextidsAttach)
{
 if ($vboptions['attachfile'])
 {
		 $attachments = $DB_site->query("
				 SELECT attachmentid, userid
				 FROM " . TABLE_PREFIX . "attachment
				 WHERE private IN (".$pmtextidsAttach.")
		 ");
		 while ($attachment = $DB_site->fetch_array($attachments))
		 {
				 $ids["$attachment[attachmentid]"] = $attachment;
		 }
		 require_once('./includes/functions_file.php');
		 delete_attachment_files($ids);
 }
 $DB_site->query("DELETE FROM " . TABLE_PREFIX . "attachment WHERE private IN (".$pmtextidsAttach.")");
}

Also, I forgot to mention earlier, you should add an index to the attachment table for the private column, it really matters for large tables. Here is the query:

ALTER TABLE attachment add index (private);

The .txt is also updated with this changes. You only need to apply them if you downloaded the txt before this post was made.