[phenomenon]

I need quick clarification that I'm not going to have security issues later -- I PM'd tigga a few days ago, but have never heard back, and I'm a bit concerned in the meantime:

I set up an if statement to have multiple 'news' pages. Basically I have a home page that reads from the News forum, then I have game pages that act as portals as well -- they read not only from their own news sections, but their own polls sections, and their own $custom templates. I did all this using and slightly altering the 'if' statement code posted earlier in this thread -- basically updated it to include swapping out custom templates for other custom templates in the if using evals. That code all works fine.

What wasn't working was setting up the $threadbits (the 'latest topics') to read from ONLY ONE SPECIFIC FORUM
on the game - pages. So to be utterly clear: My HOME page reads ALL latest threads (depending on the users perms as set in $iforumperms). The sub-game home page should read ONLY from a single public gaming forum.

There are posts in this thread on how to do this (using AND forumid!=XX in specific places in the permissions code) to exclude forums from ALL threadbits, no matter what home page or sub-home page is being used. However, in order to accomplish what I want to do, which is exclude all forums except the one I want on specific sub-home pages (my game pages), I had to copy and paste the threadbits code into my if statement, then from that specific $threadbits code I had to remove the $iforumperms:

PHP Code:

 WHERE open<>10 $iforumperms ORDER BY lastpost DESC LIMIT $maxlatethreads"); 


and replace it with AND forumid=2 like this:

PHP Code:

WHERE open<>10 AND forumid=2 ORDER BY lastpost DESC LIMIT $maxlatethreads"); 


Ok, THIS WORKED FINE -- the sub game home page seems to only read posts from that forum who's id = 2, and from nowhere else. The News page still reads from $iforumperms and shows whatever the user is allowed to see based on their group or settings.

My question is: Is this going to cause a security problem in the future that anyone can think of?

http://beast.markofthebeast.net home page
http://beast.markofthebeast.net?action=swg game page