[Briskoda]

Firstly, great hack, reading notes from proposal to install, very good material.

Apologies if this is already known, but in summary:
Auto complete IPN causes duplicate txn_id insert attempt.
Default post back of txn_id causes VERIFIED display only.
Refund sets all funds to 0.
Refund does not reduce contributors sum.

Assumption: guest processing. Not permitting guests to this page, at present...

Okay onto my experince, not sure if a few bugs are known or if it's a recent change at PayPals end.

Basically the first few payments where a manual deny was issued worked a treat, the user was returned to the success page. Although the payment was still pending in my account (to be denied or accepted) So I accepted it, thus enabling the autocomplete processing in paypal, so now each payment that comes in is appearing as completed.

So initially this hack worked, then the continue button induced the duplicate keys bug as eluded to previously, so I checked the id's all was fine, ran a few more through, same issue.

After going throught the code it seems that the IPN is beating the continue button process, but still by default it seems posting back txn_id. As such ppverify is picked up and processed where by the insert is run at 104 regardless at this point. For a completed status where the entry is already in the db I cannot see why this is needed. So I commented it out and the process began to work, except now I was rewarded with just the word VERIFIED, so I modified the paypal to do ppverify.php processing and sucess/cancel, it all seems to work again, apart from duplicated payments amounts, the update circa 139 was commented out.

I created a multitude of credits and refunds, it seems to be working now...

I then began to check what was happening for refunds, it set's all funds to 0.00 not the txn_id record passed in for the refund. Also noted the contributors table was not downdated for the refund. So I added an SQL in for that.

Has anybody else noted this behaviour, are the fixes in, if needed atall?

Does the fact I'm a UK user of paypal, the transactions appearing as complete immediatly have any bearing?

Apologies if this is a wild goose chase and I really do appreciate the hack, newborn pressures on time, so one for everybody else to ponder over

Colin.

vB2.3.0