Ok I hacked the hack so that if a thread is "invisible" it will not be shown in the users favorites.
Also it nows checks if a user has access to a thread before showing it in their favorites.
The idea is that a user may have added a thread and now has lost access to it for reasons shown in my previous post. The thread isn't actually removed from his/her list but is just not shown to them. This will allow it to "re-appear" to them if they are again given access to it. The thread table is very small as it only contains 3 id fields, the thread id, the id of the folder it goes in (if it has one) and the id of the field itself.
Below is my access checking code. My main goal has been as little database access as possible and I believe John needs to do this sort of thing in other places to help the optimization. I could have queried the database for every thread to decide to post it or not but that is bad design and something vB is very guilty of doing. My way of doing it is to build parts of your query using logic and then put your constructed query to work in the main query:
Code:
// These usergroups really need to be re-done, this is a nightmare!
// This gets the forums that our usergroup has SPECIFIC canview access to (0 or 1)
$q_perms = $DB_site->query("SELECT forumid,canview FROM forumpermission
WHERE usergroupid = $bbusergroupid");
// This gets our generic canview access
// If we do not have a specific access defined in the first query than we use the second query
// for our access to that forum.
$q_uperms = $DB_site->query_first("SELECT canview FROM usergroup WHERE usergroupid = $bbusergroupid");
$canview = $q_uperms[canview];
// $canview = 0 / We can't view any forums unless we have specific access to above
// $canview = 1 / We can view all forums unless we have specific access not to above
if ($canview == 1) // We view all forums by default, hide those we have explicit non access to
{
while ($query = $DB_site->fetch_array($q_perms))
{
$onethread = 0;
if ($query[canview] == 0)
{
if ($onethread == 0)
{
$forums .= " AND (forumid <> $query[forumid] ";
$onethread = 1;
}
else
{
$forums .= " OR forumid <> $query[forumid] ";
}
}
}
if ($onethread == 1)
{
$forums .= ")";
}
}
else // We can view no forums by default, show those we have explicit read access to
{
while ($query = $DB_site->fetch_array($q_perms))
{
$onethread = 0;
if ($query[canview] == 1)
{
if ($onethread == 0)
{
$forums .= " AND (forumid = $query[forumid] ";
$onethread = 1;
}
else
{
$forums .= " OR forumid = $query[forumid] ";
}
}
}
if ($onethread == 1)
{
$forums .= ")";
}
}
$q_thread = $DB_site->query("SELECT thread.iconid, icon.title AS icontitle, icon.iconpath, open, thread.title AS threadtitle,
lastpost, postusername,lastposter, views, replycount, fav_threads.userid, fav_threads.threadid,
fav_threads.folderid, folder
FROM fav_threads,thread
LEFT JOIN fav_folders ON (fav_threads.folderid = fav_folders.folderid)
LEFT JOIN icon ON (icon.iconid = thread.iconid)
WHERE fav_threads.userid = $bbuserid
AND thread.threadid = fav_threads.threadid
AND thread.visible = 1
$forums
ORDER by folder,thread.title");
I then take "$forums" and place it into my main query that retrieves the threads. Remember I only have one query that gets everything for showing the threads (it gets the icons, the posters, everything that is shown normally when you look at a list of threads in a normal forum). Can we say forumdisplay is need of a query optimization (I think so).
Let me put in page breaks for long pages and I will be done (which isn't easy as I like to make sure to return you to the page you were on from any function you may access)
[Edited by rangersfan on 10-24-2000 at 01:12 PM]
More Information