View Single Post
  #1  
Old 02-18-2003, 11:24 PM
Dark Jim's Avatar
Dark Jim Dark Jim is offline
 
Join Date: Apr 2002
Location: Netherlands
Posts: 174
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default Need help reducing queries

I made and submitted a hack "User Icons 1.1" just recently here but it needs quite a lot of queries on a few pages. For example it displays icons next to the user names on the who's online. The code in online.php looks like this currently:
PHP Code:
  $allusers$DB_site->query("SELECT user.username, session.location, session.lastactivity, user.userid, user.usergroupid, user.invisible, session.host, user.showemail, user.receivepm
                              FROM session, user
                              "
iif($WOLguests" LEFT JOIN user USING (userid) "",user") ."
                              WHERE session.lastactivity > 
$datecut
                              "
iif(!$WOLguests" AND session.userid = user.userid""") ."
                              ORDER BY user.username
                              "
);

  
$moderators $DB_site->query("SELECT DISTINCT userid FROM moderator");
  while (
$mods $DB_site->fetch_array($moderators)) {
    
$mod[$mods[userid]] = 1;
  }

  
$count 0;
  while (
$user $DB_site->fetch_array($allusers)) {
    if (
$user['userid']) { // Reg'd Member
      
$key $user['userid'];
      if ((
$userinfo["$key"]['lastactivity'] < $user['lastactivity']) or !$userinfo["$key"]['lastactivity']) {
        
$userinfo["$key"]['realname'] = $user['username'];
        
      
$iconavatarurl=geticonavatarurl($user['userid']);
      if (
$iconavatarurl!="") {
        
$iconavatar "<img src=\"$iconavatarurl\" border=\"0\" alt=\"\">";
      } else {
        
$iconavatar "";
      }  
      if (
$bbuserinfo[userid]>and !($bbuserinfo[showiconavatars])) {
        
$iconavatar "";
      }       
        
        if (
$user['usergroupid'] == and $highlightadmin) {
          
$userinfo["$key"]['username'] = "$iconavatar<font color={whosonlineowner}><b><i>$user[username]</i></b></font>"
Note the function "geticonavatarurl" which looks like this:
PHP Code:
// ###################### Start geticonavatarurl #######################
function geticonavatarurl($userid) {
  global 
$DB_site,$session;

  if (
$iconavatarinfo=$DB_site->query_first("SELECT user.iconavatarid,iconavatarpath,NOT ISNULL(iconavatardata) AS hascustom,customiconavatar.dateline
                                         FROM user
                                         LEFT JOIN iconavatar ON iconavatar.iconavatarid=user.iconavatarid
                                         LEFT JOIN customiconavatar ON customiconavatar.userid=user.userid
                                         WHERE user.userid='
$userid'")) {
    if (
$iconavatarinfo[iconavatarpath]!="") {
      return 
$iconavatarinfo[iconavatarpath];
    } else if (
$iconavatarinfo['hascustom']) {
      return 
"iconavatar.php?userid=$userid&dateline=$iconavatarinfo[dateline]";
    } else {
      return 
'';
    }
  }

Is it possible to merge those 2 parts of code into 1 so it only needs 1 query to display the who's online instead of 1+ 1 for each icon. I tried some stuff myself but I'm really lost here.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01250 seconds
  • Memory Usage 1,808KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_php
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete