The conditional link thing still isn't working for me. At the moment I've made it a permanent one seeing as I can't locate the problem. The code looks sound to me. Speaking of which, it's apparant that there's no error message when one attempts to unban someone not 'banned by moderators' even though I see such a message in your code. Of course, that wouldn't really matter considering the link is only supposed to show with users that fit the criteria for unbanning. For the record, the 'unban confirmation' table DOES only appear if the usergroupid is 8. Just not the unban link.
My 'banned by moderators' usergroup ID is actually 10. I don't know if that goes for everyone else or whether it depends what version of vBulletin you're using (I doubt it). This isn't the cause of any problems though. I suppose it's because my usergroup 8 is actually an admin ban which I created before moderators had banned anyone.
Personally I reckon the hack would be better if the 'unban confirmation' table didn't remain after an unban but rather you got a blank screen with the 'unbanned' message, just like you get the 'banned' one when banning. The 'confirm ban' table doesn't remain. I just noticed that if you then try to unban again (just after already unbanning a user) it gives the 'unbanned' message again and this time the 'confirm unban' table disappears (just how I think it should).
Nevertheless, the unban itself works fine.
|