Thread: mYvBindex v3.1
View Single Post
  #322  
Old 12-28-2002, 09:41 PM
Tigga's Avatar
Tigga Tigga is offline
 
Join Date: Dec 2001
Location: Atlanta
Posts: 1,061
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

1. Aha, I see.. I thought you did this from my previous vbHome versions (1.0 or 1.1).
Good to know you didn't make the same mistake like I did.

Yea, believe me I struggled with that one for a little while before I finally figured out it was the getavatarurl function that was adding the extra query.

2. Glad I could help.
Again, thanks for pointing that out and if you happened to notice any other small mistakes, by all means please point them out.

3. Use $ourtimenow instead.
Ahhh, I hadn't really seen that function since it's not used much at all in vB. Thanks for pointing it out, it may be helpful for future versions.

4. So far, from what I see you got ideas from my script on the following areas:
- alternate colors on threads function (old vbHome version)

Ahhh... Yes, you are correct about this one. I had been using that for so long and it's been so long since you've used it in vBhome that I forgot where it came from. Obviously it's the same function and idea used in vB just changed around a little, so if it bothers you that it's in there I will gladly change it.

- threads permissions
Actually that was just taken from forumdisplay.php. I believe it was PPN who posted a while ago where to find that.

- latest threads
As you know that was originally a modified version of your Latest XX Threads hack. You posted a while ago that you would prefer that it was not used, so I re-wrote that part for this version. I left the main variables the same so that people would not have to completely change their templates, but that part of the code was done from scratch.

- plural function
That idea actually came from a script called openreality. I believe (though I could be wrong) that I was actually using that on my personal site before you started using it in vBhome. The idea is so simple and basic, so of course the coding is going to be very similar.

- article
Basically you copied the code and edited a little the variables to look different.

The news part is all my code (and has been since 2.0) with parts from vBulletin files used (such as the part to pull the avatars). I did however check vBhome to see how you did the part near the top which will allow you set the news variable to 0 for no limit. I was playing with that a few months ago and for some reason could not figure out how to set the news limit where 0 would be no limit. Finally I checked to see how you had done it and felt pretty dumb afterwards since I was making such a simple mistake. (basically I didn't move the LIMIT part from the query to the part above). I didn't think it was a big deal since all I figured out from looking at your code was to move the LIMIT out of the query, which I'm sure I would have realized what a dumb mistake I was making eventually.

5. I removed that remark, but you were to fast for me, since is not my place to judge this but the mods here at vb.org. Sorry.
However, my poll and online users code is not the vBulletin one.
Feel free to compare it.

From reading the rules to posting a hack, I don't believe anything was done wrong. If so I would think an administrator would have said something by now. And I did compare the poll section again. Yes, there are quite a few changes, but the majority of the code is straight from vBulletin.

And I do apologize for being a bit rude at first, but you were wrong by saying it was adding so many queries. I couldn't understand why you were trying to say that when I knew exactly the way the script works, so I'm sure you can see why I was a bit irritated.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01154 seconds
  • Memory Usage 1,780KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete