Quote:
Originally posted by TECK
First, you use the getavatarurl() function that performs an extra query for each article you display. Is better to ask instead of complaining...
|
Maybe you should take a look at the code again. The only place the getavatarurl function is used is to pull the users avatar in the welcome box. The way I pull the news avatar will not add any extra queries at all.
PHP Code:
// News Avatar
if ($shownewsavatar) {
if ($news[avatarpath]!="") {
$newsavatarurl = "$bburl/$news[avatarpath]";
} else if ($news['hascustom']) {
$newsavatarurl = "$bburl/avatar.php?userid=$news[postuserid]&dateline=$news[avatardateline]";
} else {
$newsavatarurl = "https://vborg.vbsupport.ru/images/clear.gif";
}
eval("\$news[avatar] = \"".gettemplate("index_newsbits_avatar")."\";");
}
Quote:
Second, you really need to check your code syntax. I saw several mistakes there... like for example:
|
Thank you for pointing that out. I'm sure it's very possible that I have a typo or two in there, nobody's perfect. Something like that really isn't
that big of a deal, but if saw other mistakes please point them out to me.
Quote:
Third, if you made your own code, why do you use the time() function, when in vBulletin is already defined?
|
The time function is only used in the original vBulletin code.
PHP Code:
Do you want me also to post here what php code and functions you used from vbHome?
Please do. I've learned quite a bit about PHP since the first version of this hack and v3.0 is all original code or code straight from vBulletin, with the exception of the calendar and weather parts in which full credit is given.
Quote:
Not to mention that you infringe the Jelsoft copyright by copying several code segments onto your file...
|
If that's the case, then don't you as well? Where did the poll and online users part of your hack come from?