vb.org Archive - View Single Post - 2 Bug Fixes anyone want to help out with?

#3 09-18-2000, 08:40 PM

Quote:

Originally posted by mrogish
It seems as if users can "bump up" threads to the top of the page by making a post and subsequently deleting it. This is bad, since it brings up threads from long ago without any warning. Once they delete it, it should go back to where it once was.

I haven't taken a look at it yet, but I am going to sit down and fix this bug and I was wondering if anyone else has:

a) encountered it
a.1) and fixed it
b) has heard of a fix
c) wants to help me fix it

Haven't fixed it but I can give you some theory on it if you want

In the delete post routines, you have to develop a check to see if the post is the last in the thread. This code should do it:

Code:

$thread=$DB_site->query_first("SELECT threadid FROM post WHERE postid='$postid'");
$threadid=$thread[threadid];
$islast=$DB_site->query_first("SELECT postid FROM post WHERE threadid='$threadid' ORDER BY dateline LIMIT 0,1");
if ($postid==$islast[postid]) {
if ($issecondlast=$DB_site->query_first("SELECT dateline FROM post WHERE threadid='$threadid' ORDER BY dateline LIMIT 1,1")) {
$DB_site->query("UPDATE thread SET lastpost='$issecondlast[dateline]' WHERE threadid='$threadid'");
}
}

Hey, woah - I just like wrote the hack! LOL. Of course, that's not accounting for any of the code already in there. You probably don't need all that because it's partly redundant.
[Note: That code is completely untested]
Note that I left out the DESC part from the dateline - this should get the oldest post.

Quote:

Also, the second bug seems to be that regular users can unlock their posts regardless of the setting in the control panel. Anyone else know more about this?

(You can imagine how we discovered this, mod-locked threads mysteriously float up to the top of the board, unlocked with no explanations.)

So we know who's been unlocking them (the original posters), but we can't do anything about it!!!

I don't think that's a bug - you might want to check your usergroup permissions.

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01080 seconds Memory Usage 1,766KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (1)bbcode_code (2)bbcode_quote (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: