Couple of problems I found:
1. I don't know if it's a problem with vbhacker generating the text file of changes or the hack is incorrect.
Code:
+-------------------------------------------------------------------------------------------------+
| In admin/template.php, replace this code: |
+-------------------------------------------------------------------------------------------------+
$only[\'showgroup\'] = \'Show Groups\';
+-------------------------------------------------------------------------------------------------+
+-------------------------------------------------------------------------------------------------+
| With this code: |
+-------------------------------------------------------------------------------------------------+
$only[\'home\'] = \'vBindex\';
+-------------------------------------------------------------------------------------------------+
Shouldn't this line be inserted after the code found instead of replaced?
Code:
+-------------------------------------------------------------------------------------------------+
| In admin/usergroup.php, replace this code: |
+-------------------------------------------------------------------------------------------------+
makeyesnocode("Can view board","canview",1);
+-------------------------------------------------------------------------------------------------+
+-------------------------------------------------------------------------------------------------+
| With this code: |
+-------------------------------------------------------------------------------------------------+
// vBindex Edit
makeyesnocode("Can view vBindex?","canviewvbindex,1");
// vBindex Edit
+-------------------------------------------------------------------------------------------------+
Same as above question plus the replacement text is bad.
"canviewvbindex,1" should be
"canviewvbindex",1
2. The poll query takes extreme amount of time to complete. I think it's not constructed properly but maybe it's a bug in my version of MySQL.
This code:
Code:
$pollinfo=$DB_site->query_first("SELECT *,thread.open FROM poll LEFT JOIN thread ON (thread.pollid = poll.pollid) WHERE thread.forumid='$pollsforum' ORDER BY poll.dateline DESC LIMIT 1");
Should be:
Code:
$pollinfo=$DB_site->query_first("SELECT poll.*,thread.open FROM thread LEFT JOIN poll ON (thread.pollid=poll.pollid) WHERE thread.forumid='$pollsforum' ORDER BY poll.dateline DESC LIMIT 1");
And of course code appropriately changed to reflect query change.