Thread: vBindex v2.1
View Single Post
  #506  
Old 09-21-2002, 09:27 AM
MiF MiF is offline
 
Join Date: Jan 2002
Posts: 4
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Couple of problems I found:

1. I don't know if it's a problem with vbhacker generating the text file of changes or the hack is incorrect.

Code:
+-------------------------------------------------------------------------------------------------+
| In admin/template.php, replace this code:                                                       |
+-------------------------------------------------------------------------------------------------+
$only[\'showgroup\'] = \'Show Groups\';
+-------------------------------------------------------------------------------------------------+

+-------------------------------------------------------------------------------------------------+
| With this code:                                                                                 |
+-------------------------------------------------------------------------------------------------+
$only[\'home\'] = \'vBindex\';
+-------------------------------------------------------------------------------------------------+
Shouldn't this line be inserted after the code found instead of replaced?

Code:
+-------------------------------------------------------------------------------------------------+
| In admin/usergroup.php, replace this code:                                                      |
+-------------------------------------------------------------------------------------------------+
makeyesnocode("Can view board","canview",1);
+-------------------------------------------------------------------------------------------------+

+-------------------------------------------------------------------------------------------------+
| With this code:                                                                                 |
+-------------------------------------------------------------------------------------------------+
// vBindex Edit
makeyesnocode("Can view vBindex?","canviewvbindex,1");
// vBindex Edit
+-------------------------------------------------------------------------------------------------+
Same as above question plus the replacement text is bad. "canviewvbindex,1" should be "canviewvbindex",1

2. The poll query takes extreme amount of time to complete. I think it's not constructed properly but maybe it's a bug in my version of MySQL.

This code:

Code:
$pollinfo=$DB_site->query_first("SELECT *,thread.open FROM poll LEFT JOIN thread ON (thread.pollid = poll.pollid) WHERE thread.forumid='$pollsforum' ORDER BY poll.dateline DESC LIMIT 1");
Should be:

Code:
$pollinfo=$DB_site->query_first("SELECT poll.*,thread.open FROM thread LEFT JOIN poll ON (thread.pollid=poll.pollid) WHERE thread.forumid='$pollsforum' ORDER BY poll.dateline DESC LIMIT 1");
And of course code appropriately changed to reflect query change.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01213 seconds
  • Memory Usage 1,773KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (4)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete