[TECK]

Originally posted by KuraFire
I haven't been keeping up with this thread for a while, but I noticed a 'flaw' in this hack that is rather scary...

When I installed it (just after the 226 db_mysql.php came out) it didn't add the $query_count var. to the query_first function. The Query_first function is, however, as the name implies, another function using queries, and all these queries were omitted since there was no global $query_count and $query_count++; part palced in it. If you do, you'll suddenly notice how much queries are added. On my board, the count went up with an average of 15 queries. Those are all queries with limit 1 (the query_first function) but still queries. I don't think that's a very good thing....

I'm probably missing out on some info here, but to me, that seems bad. Showthread pages now have a standard of 46 queries on average, with a few 1-query hacks installed.... :/

this hack doesnt add any query, it only give you the opportunity to see what it's happening behing php and mysql, on every page. it's doing this by only using the microtime function built in php. the rest of functions are used as default by vbulletin.

here it is an example of the original db_mysql.php:

  function query($query_string) {
    global $query_count,$showqueries,$explain,$querytime;
    // do query

as you notice, $query_count is present there, in the original file. the only mods i did is to allow to insert the microtime at the beginning and end of page so i can see exacly the time it took to generate the page.
i recommend you to download the latest vb226 package from members area and look at the db_mysql.php file. then to modify it properly. there have been several versions of this file and my hack includes instructions with the latest downloadable .zip file from members area.
also, i dont see where you added query_first string, because is not required in my hack.

at no time you will see 15queries added. this is related to other hacks you added, not vbMicroStats.