The settings don't have the same 'look' as your screen image shows for the color selections, nor as the code in product-enhancedthreadreviewmarkfl.xml indicates it should. This is what the settings screen contain for us. Also note, that even though in the updated product-enhancedthreadreviewmarkfl.xml it indicates <version>3.5</version>, it still shows 3.4 when installed.
Update:
As to why I'm not seeing color pickers in your MOD has been figured out.
I'm using Apple's Safari browser, as I'm on macOS Sierra and/or iOS (iPad/iPhone). In that browser the color pickers don't display, and instead are shown as replaceable hexadecimal values.
The thought that this might be the cause had me fire up one of my Linux VM's and login to the AdminCP using Firefox. In that browser the color pickers do show as in your screenshot, and as you said you observed when you were logged in.
So it's a browser issue, and one that I think you dealt with in an earlier MOD you wrote for me just recently.