vb.org Archive - View Single Post

Size · #65 06-05-2002, 06:48 PM

Look at this piece of code in inactiveusers.php

Code:

while ($row=$DB_site->fetch_array($result) and ++$bgcounter) {
	$bgcolor = iif($bgcounter%2==0, 'firstalt', 'secondalt');
	$ddate=time();
	$isinactive=$ddate-$row["joindate"];
	if (($row["lastpost"]==0)&&($isinactive>$timeactive)) {
		$yninactive="<a href=\"user.php?s=$session[sessionhash]&action=remove&userid=".$row["userid"]."\" target='_blank'><font color=\"#FF0000\">YES!</font></a>";
	} else {
		$yninactive="No</font>";
	}
	if ($row["lastpost"]==0) { 
		$lastpost="<font color=\"red\">NEVER</font>";
	}else { 
		$timefull=time();
		$lastpost=date("m-d-Y h:i A", $row["lastpost"]);
	}
	$extendateLA=date("m-d-Y h:i A", $row["lastactivity"]);
	$extendateJD=date("m-d-Y h:i A", $row["joindate"]);
        echo ("<tr class=\"$bgcolor\"><td align=\"left\">".$row["userid"]."</td><td align=\"left\"><a href='../member.php?s=$session[sessionhash]&action=getinfo&userid=$row[userid]' target='_blank'>".$row["username"]."</a></td><td align=\"left\">$extendateJD</td><td align=\"left\">$lastpost</td><td align=\"left\">$extendateLA</td><td align=\"center\">".$row["posts"]."</td><td align=\"left\">".$row["ipaddress"]."</td><td align=\"left\">$yninactive</td></tr>");
}

in this if-else structure

Code:

if (($row["lastpost"]==0)&&($isinactive>$timeactive)) {
		$yninactive="<a href=\"user.php?s=$session[sessionhash]&action=remove&userid=".$row["userid"]."\" target='_blank'><font color=\"#FF0000\">YES!</font></a>";
	} else {
		$yninactive="No</font>";
	}

delete the else {.....}, and move the closing } for the if to right before the closing } for the while loop. The altered code looks like this:

Code:

while ($row=$DB_site->fetch_array($result) and ++$bgcounter) {
	$bgcolor = iif($bgcounter%2==0, 'firstalt', 'secondalt');
	$ddate=time();
	$isinactive=$ddate-$row["joindate"];
	if (($row["lastpost"]==0)&&($isinactive>$timeactive)) {
		$yninactive="<a href=\"user.php?s=$session[sessionhash]&action=remove&userid=".$row["userid"]."\" target='_blank'><font color=\"#FF0000\">YES!</font></a>";
	
	if ($row["lastpost"]==0) { 
		$lastpost="<font color=\"red\">NEVER</font>";
	}else { 
		$timefull=time();
		$lastpost=date("m-d-Y h:i A", $row["lastpost"]);
	}
	$extendateLA=date("m-d-Y h:i A", $row["lastactivity"]);
	$extendateJD=date("m-d-Y h:i A", $row["joindate"]);
        echo ("<tr class=\"$bgcolor\"><td align=\"left\">".$row["userid"]."</td><td align=\"left\"><a href='../member.php?s=$session[sessionhash]&action=getinfo&userid=$row[userid]' target='_blank'>".$row["username"]."</a></td><td align=\"left\">$extendateJD</td><td align=\"left\">$lastpost</td><td align=\"left\">$extendateLA</td><td align=\"center\">".$row["posts"]."</td><td align=\"left\">".$row["ipaddress"]."</td><td align=\"left\">$yninactive</td></tr>");
	}
}

You're welcome in advance

X vBulletin 3.8.12 by vBS Debug Information
Page Generation 0.01124 seconds Memory Usage 1,780KB Queries Executed 11 (?)
More Information
Template Usage: (1)SHOWTHREAD_SHOWPOST (1)ad_footer_end (1)ad_footer_start (1)ad_header_end (1)ad_header_logo (1)ad_navbar_below (3)bbcode_code (1)footer (1)gobutton (1)header (1)headinclude (6)option (1)post_thanks_box (1)post_thanks_button (1)post_thanks_javascript (1)post_thanks_navbar_search (1)post_thanks_postbit_info (1)postbit (1)postbit_onlinestatus (1)postbit_wrapper (1)spacer_close (1)spacer_open Phrase Groups Available: global postbit reputationlevel showthread	Included Files: ./showpost.php ./global.php ./includes/init.php ./includes/class_core.php ./includes/config.php ./includes/functions.php ./includes/class_hook.php ./includes/modsystem_functions.php ./includes/functions_bigthree.php ./includes/class_postbit.php ./includes/class_bbcode.php ./includes/functions_reputation.php ./includes/functions_post_thanks.php Hooks Called: init_startup init_startup_session_setup_start init_startup_session_setup_complete cache_permissions fetch_postinfo_query fetch_postinfo fetch_threadinfo_query fetch_threadinfo fetch_foruminfo style_fetch cache_templates global_start parse_templates global_setup_complete showpost_start bbcode_fetch_tags bbcode_create postbit_factory showpost_post postbit_display_start post_thanks_function_post_thanks_off_start post_thanks_function_post_thanks_off_end post_thanks_function_fetch_thanks_start post_thanks_function_fetch_thanks_end post_thanks_function_thanked_already_start post_thanks_function_thanked_already_end fetch_musername postbit_imicons bbcode_parse_start bbcode_parse_complete_precache bbcode_parse_complete postbit_display_complete post_thanks_function_can_thank_this_post_start showpost_complete
Messages: