[MarkFL]

Originally Posted by ikopylov

Hi Mark!
Minor bugs in mod Featured Threads v1.9.7

1
Replase all phrases to {vb:rawphrase vb_standart_phrase}
This is for non English forums

2
Find and replase
<br> ==> <br />
<img src="' . $icon . '">'; ==> <img src="' . $icon . '" alt="" />';
<input bla-bla-bla> ==> <input bla-bla-bla />
<hr></hr> ==> <hr />


3
This is for forums with UTF8:

$preview = substr($firstpost['pagetext'], 0, $vbulletin->options['threadpreview']);

==>

$preview = iconv_substr($firstpost['pagetext'], 0, $vbulletin->options['threadpreview'], 'UTF-8');

next

$forum_trunc = strlen($forum_name) > $forum_length ? substr($forum_name,0,$forum_length) . "...": $forum_name;

==>

$forum_trunc = strlen($forum_name) > $forum_length ? iconv_substr($forum_name,0,$forum_length, 'UTF-8') . "...": $forum_name;

4
Some forums have a short URL:
Member, Forum, Thread

return '<a title="' . $title . '" href="member.php?' . $user_name['userid'] . '-' . $user_name['username'] . '" target="_blank">' . $open_tag . $user_name['username'] . $close_tag . '</a>';

==>

return '<a title="' . $title . '" href="member.php?u=' . $user_name['userid'] . '" target="_blank">' . $open_tag . $user_name['username'] . $close_tag . '</a>';

next

$thread .= '<a title="' . get_thread_preview($threadinfo['firstpostid']) . '" style="color: ' . $vbulletin->options['markfl_ft_linkcolor'] . '; ' . $vbulletin->options['markfl_ft_linkformat'] .'" href="showthread.php?' . $threadinfo['threadid'] . '-' . str_replace(' ', '-', $threadinfo['title']) . '">' . $threadinfo['title'] . '</a>';

==>

$thread .= '<a title="' . get_thread_preview($threadinfo['firstpostid']) . '" style="color: ' . $vbulletin->options['markfl_ft_linkcolor'] . '; ' . $vbulletin->options['markfl_ft_linkformat'] .'" href="showthread.php?t=' . $threadinfo['threadid'] . '">' . $threadinfo['title'] . '</a>';

next

return '<td style="border-right: ' . $vbulletin->options['markfl_ft_border'] . '"><a title="' . $ftitle . '" style="color: ' . $vbulletin->options['markfl_ft_linkcolor'] . '; ' . $vbulletin->options['markfl_ft_linkformat'] .'" href="forumdisplay.php?' . $ftthread['forumid'] . '-' . str_replace(' ', '-', $vbulletin->forumcache[$ftthread['forumid']]['title'])  . '">' . $forum_trunc . '</a></td>';

==>

return '<td style="border-right: ' . $vbulletin->options['markfl_ft_border'] . '"><a title="' . $ftitle . '" style="color: ' . $vbulletin->options['markfl_ft_linkcolor'] . '; ' . $vbulletin->options['markfl_ft_linkformat'] .'" href="forumdisplay.php?f=' . $thread['forumid'] . '">' . $forum_trunc . '</a></td>';

1.) Using phrasing (a HUGE task) is on my to-do list. It could be a while before I can get to it.

2.) Those slashes add no functionality to HTML and are not necessary.

3.) I will eventually look into adding UTF-8 encoding functionality. I'm learning as I go.

4.) I tried giving URLs that are the most standard, and play nicely with SEO mods.