Thread: Moderators Functions - Show User History On Infraction Form And Postbits
View Single Post
  #42  
Old 07-12-2015, 04:42 AM
BrettC Frontier BrettC Frontier is offline
 
Join Date: Jun 2015
Posts: 36
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

Hi Mark,

A few bugs/issues/requests to report of on this addon.


- The text in the ACP, products, your product name shows as "MarkFL: Show Usernotes And Infraction History On I". Seems to have hit a limit or something.

- Would be nice to change the check boxes on the usergroup selection into a select box. Selected group names would be active, unselected would be inactive.

- The yellow background and text do not play nice with one another on the blue vbulletin admin theme. White text on yellow.

- Within user notes, if a title field is empty, it may be worth while putting N/A into the field as a placeholder.

- Within Warnings/Infractions:
  • The reason field always has a / somewhere. It would appear the slash in the code is a delimiter between a custom infraction reason and a preset reason. May be worthwhile using a "if ? :" Ternary operator php clause in that segment.
  • Infraction list does not show expiry time.
  • Infraction list does not show infraction type: warning/infraction text, only a numerical point value. May be worthwhile using the infraction icon images.
  • Infraction list does not link to the post/item that was infracted.

Observed on both sections:
- Dark themes absolutely decimate the text coloring of the rows to background coloring. The rows appear to not use vbulletin's CSS variables of blockrow, blockhead as seen elsewhere in VB.

- Having user notes and infractions all in the same blob of text is rather confusing. Moving user notes to the left side, and moving infractions to the right made the segments much more readable.

- The text bubble assigned to administrative notes on infractions should default to N/A or "No Administrative Note Assigned" if no text was put there.

- The postbit hooking appears to completely fail if there's been any edits to the segments near post counts/userinfo bits.

- Issued By / Author username is not linkable.

- "User Notes: ###" could have an additional link to the right for "Manage User Notes".

- "Warnings/Infractions" could have a link to the users profile page. For example: /member.php?u=#####&tab=infractions&pp=40#infractio ns-content


Sorry for the wall of text. Just a few knacks to advise of.
Reply With Quote
2 благодарности(ей) от:
Alan_SP, MarkFL
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01729 seconds
  • Memory Usage 1,770KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (2)post_thanks_box_bit
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • fetch_musername
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • post_thanks_function_fetch_thanks_bit_start
  • post_thanks_function_show_thanks_date_start
  • post_thanks_function_show_thanks_date_end
  • post_thanks_function_fetch_thanks_bit_end
  • post_thanks_function_fetch_post_thanks_template_start
  • post_thanks_function_fetch_post_thanks_template_end
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete