View Single Post
  #14  
Old 05-27-2015, 09:45 AM
Skyrider Skyrider is offline
 
Join Date: Feb 2006
Location: Netherlands
Posts: 1,392
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

I'm pretty sure that the execution order is screwed up.

I have this as execution order 2,3 and even tried 4:
Code:
$userdata_rank->set('usergroupid', 42);
$userdata_rank->save();
at a specific hook when forum members link their steam account. Simple enough, move user to UsergroupID 42.

This works great, awesome!

Now I've added another plugin to check if the user has been flagged on SteamREP.com as a scammer.

I've disabled the usergroupID 42 move plugin to see after I steam linked my profile on the forums I would be banned.. and, it works!

Now, if I enable both of them (move usergroupdID execution order 2, 3 or 4) with the second steamrep ban plugin execution order 1. I get moved to usergroupID 42, rather than the specific steamrep banned usergroup of which is 26.

So, which made me wonder.. what if execution order 2, 3 or 4 beats 1? So I used the following code at the plugin with execution 2, 3 or 4 (tried all 3):

Code:
if (!in_array($vbulletin->userinfo['usergroupid'], array(26)) )
{
$userdata_rank->set('usergroupid', 42);
$userdata_rank->save();
}
26 is ignored, and tada..!! everything suddenly worked.

Now, once again.. why isn't execution order doing its job? Both of these plugins are using the exact same hook. Is it broken? Has anyone tested it? Does execution order depends on the amount of the code? If one is smaller than the other, second one is being executed faster? What's the deal?
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01093 seconds
  • Memory Usage 1,766KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete