View Single Post
  #2243  
Old 04-16-2015, 07:31 PM
squidsk's Avatar
squidsk squidsk is offline
 
Join Date: Nov 2010
Posts: 969
Благодарил(а): 0 раз(а)
Поблагодарили: 0 раз(а) в 0 сообщениях
Default

A bug in your code that prevents access to the member profile pages.

In the file includes/functions_tal.php you have the following code:
Code:
if (!in_array(THIS_SCRIPT, array('ladders', 'competitors', 'tournaments', 'teams')) && !$vbulletin)
{
	global $vbulletin;
	print_r("<!-- Non-standard page, trying global vbulletin variable -->\r\n");
}
if (!$vbulletin->options['tmnt_active'] && $vbulletin->userinfo['usergroupid'] != 6)
{
	print_r("<!-- vBulletin Tournaments &amp; Ladders disabled in AdminCP -->\r\n");
	print_no_permission();
}
If the tournament mod isn't active then memberinfo.php is not accessible to non-admins. The code should be changed by having the second if statement nested inside the first, so the tournament mod active check only executes on tournament mod specific pages.

Code:
global $vbulletin; //just globalize no need to test if it exists you don't gain anything
if (in_array(THIS_SCRIPT, array('ladders', 'competitors', 'tournaments', 'teams')))
{
	print_r("<!-- Non-standard page, trying global vbulletin variable -->\r\n");
	if (!$vbulletin->options['tmnt_active'] && $vbulletin->userinfo['usergroupid'] != 6)
	{
		print_r("<!-- vBulletin Tournaments &amp; Ladders disabled in AdminCP -->\r\n");
		print_no_permission();
	}
}
This way if you are on a tournament specific page and the tournament mod is disabled you won't be able to access it unless you are an admin. This also makes sure that the member profile page (since includes/functions_tal.php is included in the User Profile Tab (member_complete hook) plugin is accessible even if the tournament mod is inactive.
Reply With Quote
 
X vBulletin 3.8.12 by vBS Debug Information
  • Page Generation 0.01239 seconds
  • Memory Usage 1,763KB
  • Queries Executed 11 (?)
More Information
Template Usage:
  • (1)SHOWTHREAD_SHOWPOST
  • (1)ad_footer_end
  • (1)ad_footer_start
  • (1)ad_header_end
  • (1)ad_header_logo
  • (1)ad_navbar_below
  • (2)bbcode_code
  • (1)footer
  • (1)gobutton
  • (1)header
  • (1)headinclude
  • (6)option
  • (1)post_thanks_box
  • (1)post_thanks_button
  • (1)post_thanks_javascript
  • (1)post_thanks_navbar_search
  • (1)post_thanks_postbit_info
  • (1)postbit
  • (1)postbit_onlinestatus
  • (1)postbit_wrapper
  • (1)spacer_close
  • (1)spacer_open 

Phrase Groups Available:
  • global
  • postbit
  • reputationlevel
  • showthread
Included Files:
  • ./showpost.php
  • ./global.php
  • ./includes/init.php
  • ./includes/class_core.php
  • ./includes/config.php
  • ./includes/functions.php
  • ./includes/class_hook.php
  • ./includes/modsystem_functions.php
  • ./includes/functions_bigthree.php
  • ./includes/class_postbit.php
  • ./includes/class_bbcode.php
  • ./includes/functions_reputation.php
  • ./includes/functions_post_thanks.php 

Hooks Called:
  • init_startup
  • init_startup_session_setup_start
  • init_startup_session_setup_complete
  • cache_permissions
  • fetch_postinfo_query
  • fetch_postinfo
  • fetch_threadinfo_query
  • fetch_threadinfo
  • fetch_foruminfo
  • style_fetch
  • cache_templates
  • global_start
  • parse_templates
  • global_setup_complete
  • showpost_start
  • bbcode_fetch_tags
  • bbcode_create
  • postbit_factory
  • showpost_post
  • postbit_display_start
  • post_thanks_function_post_thanks_off_start
  • post_thanks_function_post_thanks_off_end
  • post_thanks_function_fetch_thanks_start
  • post_thanks_function_fetch_thanks_end
  • post_thanks_function_thanked_already_start
  • post_thanks_function_thanked_already_end
  • fetch_musername
  • postbit_imicons
  • bbcode_parse_start
  • bbcode_parse_complete_precache
  • bbcode_parse_complete
  • postbit_display_complete
  • post_thanks_function_can_thank_this_post_start
  • showpost_complete